-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typos] Move the log related to the attribute reads for chip-tool a f… #27043
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_LogTypo
Jun 5, 2023
Merged
[typos] Move the log related to the attribute reads for chip-tool a f… #27043
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_LogTypo
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
June 2, 2023 15:04
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
vijs,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 2, 2023 15:04
PR #27043: Size comparison from e19d9d8 to 057ccf4 Increases (10 builds for esp32, psoc6, telink)
Decreases (13 builds for bl602, bl702, cc32xx, cyw30739, esp32, linux, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jun 2, 2023
bzbarsky-apple
approved these changes
Jun 2, 2023
…ew lines up otherwise the header appears before the list of attributes
vivien-apple
force-pushed
the
ChipTool_LogTypo
branch
from
June 5, 2023 07:45
057ccf4
to
a9184c6
Compare
PR #27043: Size comparison from 275341e to a9184c6 Increases (9 builds for bl602, bl702, esp32, psoc6, telink)
Decreases (9 builds for bl602, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ew lines up otherwise the header appears before the list of attributes
Problem
This PR just fix a typo where the logs are misplaced. The header appears before the content that is generated
InteractionModelConfig::GetAttributePaths
...