-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update decision to build java-controller to Linux. #27037
Merged
andy31415
merged 3 commits into
project-chip:master
from
andy31415:fix_java_decision_logic
Jun 5, 2023
Merged
Update decision to build java-controller to Linux. #27037
andy31415
merged 3 commits into
project-chip:master
from
andy31415:fix_java_decision_logic
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because current dependencies will validate that we use linux underneath and when compiling say esp32 on a vscode image with JAVA_PATH set, compilation would fail. Later on we can update/decide if java compilation should happen on mac as well. CI only compiles and validates linux.
PR #27037: Size comparison from 3f768f2 to 26cda83 Increases (14 builds for bl702, esp32, psoc6, qpg, telink)
Decreases (8 builds for bl602, cc32xx, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27037: Size comparison from 24e829b to 1532c48 Increases (8 builds for bl602, cyw30739, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc32xx, efr32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27037: Size comparison from be6e4b6 to d540079 Increases (9 builds for bl602, bl702, psoc6, qpg, telink)
Decreases (12 builds for bl702, cc32xx, cyw30739, esp32, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because current dependencies will validate that we use linux underneath and when compiling say esp32 on a vscode image with JAVA_PATH set, compilation would fail.
Later on we can update/decide if java compilation should happen on mac as well. CI only compiles and validates linux.