[Thread]Add a GenericThreadDriver constructor to set 2 private timeout variab… #27016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #27016: Size comparison from 1887986 to ad915bc Increases (14 builds for bl702, cyw30739, efr32, nrfconnect, psoc6, qpg)
Decreases (4 builds for bl602, bl702, psoc6)
Full report (37 builds for bl602, bl702, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, psoc6, qpg)
|
…le, Add setter for those same variables so user cand modify them at runtime if they need to.
jmartinez-silabs
force-pushed
the
configurable_thread_timeouts
branch
from
ad915bc to
07d4f8f
Compare
bzbarsky-apple
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Looks reasonable, but watch out for conflicts with #26940 -- these approaches are mutually incompatible, and we should figure out which one we want.
yufengwangca
approved these changes
Jun 1, 2023
|
PR #27016: Size comparison from 28e0423 to 07d4f8f Increases (31 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, nrfconnect, qpg, telink)
Decreases (4 builds for bl602, bl702, psoc6)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
I would suggest moving this to Another idea is to add GenericThreadDriver is actually in the middle of the stack when commissioning the Thread network. The top layer is the cluster, and the bottom layer is the We should notice that this PR does not actually allow the application to override these two values, since the driver is instanced at It is possible that different platforms (and Thread implementations) uses different suggested values for these two values, they might be backed with slightly different We could then expose two other functions, to allow applications override these two value when (or after) initializing thread stack by calling |
|
@erjiaqing thank you for your input. I will rework this in a few days so it is applicable to your PR and be leveraged by other ThreadStackImpl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le, Add a setter for those same variables so users can modify them at runtime if they need to.
Devices could desire to increase their set timeouts in noisy environments for example.