-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] In interactive server mode when a response is sent over t… #27006
[chip-tool] In interactive server mode when a response is sent over t… #27006
Conversation
PR #27006: Size comparison from 1ae7c93 to caaced6 Increases (9 builds for bl602, cc32xx, esp32, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, bl702, linux, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/chip-tool/commands/interactive/InteractiveCommands.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but stringstream seems like it might be even better, as @andy31415 notes.
caaced6
to
26e6169
Compare
PR #27006: Size comparison from e19d9d8 to 26e6169 Increases above 0.2%:
Increases (10 builds for linux, psoc6, telink)
Decreases (10 builds for bl602, bl702, linux, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@vivien-apple Note the build errors. |
8438cf4
to
2a41daf
Compare
PR #27006: Size comparison from 275341e to 2a41daf Increases above 0.2%:
Increases (8 builds for esp32, linux, psoc6, telink)
Decreases (15 builds for bl602, cc32xx, cyw30739, linux, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
2a41daf
to
2cd6170
Compare
PR #27006: Size comparison from a90199c to 2cd6170 Increases above 0.2%:
Increases (8 builds for bl602, cc32xx, esp32, linux, nrfconnect, telink)
Decreases (11 builds for bl702, esp32, linux, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/chip-tool/commands/interactive/InteractiveCommands.cpp
Outdated
Show resolved
Hide resolved
2cd6170
to
c0ca4c7
Compare
PR #27006: Size comparison from 4f6923f to c0ca4c7 Decreases (3 builds for bl602, bl702, cc32xx)
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
|
c0ca4c7
to
78523e1
Compare
PR #27006: Size comparison from 4f6923f to 78523e1 Increases (5 builds for esp32, linux, psoc6, telink)
Decreases (14 builds for bl602, bl702, cc32xx, cyw30739, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…he wire it keeps creating new strings instead of concatening to the already existing strings
78523e1
to
8a67191
Compare
PR #27006: Size comparison from a9cb637 to 8a67191 Increases (7 builds for bl702, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for bl602, bl702, esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…he wire it keeps creating new strings instead of concatening to the already existing strings
Problem
When building large strings of text that will be sent over WebSocket it takes a long time. This is because the string is built at the end and instead of "just" concatenating the code builds new strings all the time. I have observed some WebSocket timeout without this patch for strings that ends up taking megabytes. With this patch I can't tell there is a delay.