-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Increase the maximum message size that can be rece… #27005
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_IncreaseWebSocketMaxMessageSize
Jun 5, 2023
Merged
[matter_yamltests] Increase the maximum message size that can be rece… #27005
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_IncreaseWebSocketMaxMessageSize
Jun 5, 2023
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
June 1, 2023 12:40
pullapprove
bot
requested review from
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 1, 2023 12:40
PR #27005: Size comparison from 1ae7c93 to d7b7888 Increases (11 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Decreases (8 builds for bl702, cyw30739, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 1, 2023
vivien-apple
force-pushed
the
MatterYamlTests_IncreaseWebSocketMaxMessageSize
branch
from
June 2, 2023 14:49
d7b7888
to
895dbc0
Compare
PR #27005: Size comparison from e19d9d8 to 895dbc0 Increases (7 builds for cc32xx, esp32, psoc6, telink)
Decreases (13 builds for bl602, bl702, esp32, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jun 2, 2023
…ived by the websocket
vivien-apple
force-pushed
the
MatterYamlTests_IncreaseWebSocketMaxMessageSize
branch
from
June 5, 2023 08:00
895dbc0
to
d042d5d
Compare
PR #27005: Size comparison from 275341e to d042d5d Increases (5 builds for esp32, psoc6, telink)
Decreases (13 builds for bl602, bl702, cc32xx, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ived by the websocket
Problem
When using YAML commands that returns a large amount of data, it may be bigger than the current allowed size for web socket messages.
This PR raise the allowed amount of data to be 10MB. This is 4 times bigger than the maximum amount of data I have observed but I don't want to have to increase this value all the time if I ever end up adding additional informations to what is reported by the web socket and in practice it does not hurt.