-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate hookable tracing module #26986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha and
emargolis
May 31, 2023 19:49
pullapprove
bot
requested review from
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 31, 2023 19:49
PR #26986: Size comparison from 77b1596 to 8bd4cf5 Full report (2 builds for cc32xx, mbed)
|
PR #26986: Size comparison from 77b1596 to 9536ec4 Increases (11 builds for bl602, bl702, cc32xx, cyw30739, psoc6, telink)
Decreases (7 builds for esp32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 31, 2023
tcarmelveilleux
approved these changes
Jun 1, 2023
PR #26986: Size comparison from 5d913c9 to 6ff2e47 Increases (6 builds for bl602, bl702, nrfconnect, psoc6, qpg)
Decreases (4 builds for bl702, cc32xx, cyw30739, k32w)
Full report (40 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #26986: Size comparison from 5d913c9 to dd68666 Increases (18 builds for bl702, esp32, linux, nrfconnect, psoc6, telink)
Decreases (21 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, nrfconnect, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to solve the difficulty in figuring out what applications are doing (e.g. java matter controller tests fail occasionally and I still do not know why).
We do have the infrastructure, however it is rarely actually used:
examples/tracing
which is not the same assrc/trace
but rather usesMessageTracing.h
This just adds a generic tracing backend with some unit tests.
Intent is to have followups for:
examples/tracing
(TraceStream/TraceLog/TraceFile/...)Overall goal is to be able to figure out "what went wrong in a failed commissioning" (as an example) within minutes of having a log. Today I have seen people knowing the SDK well spending hours in log reading + wireshark captures to figure out things and I believe we can improve on that.