-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out java/kotlin unit tests #26897
Merged
Merged
+93
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms instead of 400ms
This moves java dependency download time from 500ms to 5ms after the initial download. If we get more dependencies, the savings should be even better.
github-actions
bot
added
controller
examples
github
gn
lib
scripts
setup payload
support
workflows
labels
May 26, 2023
pullapprove
bot
requested review from
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 26, 2023 20:07
PR #26897: Size comparison from 3d521b0 to e9f8bcb Increases (4 builds for bl602, bl702, cc32xx, nrfconnect)
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
|
PR #26897: Size comparison from 3d521b0 to bec3c24 Increases (13 builds for bl702, cc32xx, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, efr32, esp32, nrfconnect, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 27, 2023
PR #26897: Size comparison from df1f7a8 to 60c2906 Increases (8 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Decreases (11 builds for bl602, bl702, cc13x4_26x4, efr32, k32w, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently java and kotlin unit tests were built as part of the matter-controller and did not seem to be run.
Changes in the PR:
As a separate followup I will have to make
run_tests
actually run all tests defined in build rules instead of hard-coding them.