-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Increase the keep alive timeout for websockets #26870
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_KeepAliveTimeout
May 26, 2023
Merged
[matter_yamltests] Increase the keep alive timeout for websockets #26870
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_KeepAliveTimeout
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
May 26, 2023 09:39
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 26, 2023 09:39
PR #26870: Size comparison from e00843e to c0531e2 Increases (12 builds for bl602, cc13x2_26x2, cc13x4_26x4, cc32xx, esp32, psoc6, telink)
Decreases (11 builds for bl702, efr32, esp32, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 26, 2023
Fast-tracking test improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running the YAML tests over WebSocket in CI it seems that we are sometimes loosing the TCP connection with an error:
Some examples of such failures are https://github.com/project-chip/connectedhomeip/actions/runs/5074186491/jobs/9114097979 and https://github.com/project-chip/connectedhomeip/actions/runs/5080391093/jobs/9127295759?pr=26822
My current theory is that keep-alive ping-pong takes times on some CI runs because of the machine where it is running beeing under heavy load and the commissioner and commissionee are already busy sending pairing messages.
If that is, incrementing the keep-alive timeout should be enough to solve the issue. This PR raise the default keep-alive timeout from
20
to40
seconds.