-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change OptionalQRCodeInfo to data class #26849
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yufengwangca:pr/java/setup
May 26, 2023
Merged
Change OptionalQRCodeInfo to data class #26849
yunhanw-google
merged 1 commit into
project-chip:master
from
yufengwangca:pr/java/setup
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
May 25, 2023 16:22
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs and
vivien-apple
May 25, 2023 16:22
pullapprove
bot
requested review from
woody-apple,
xylophone21 and
younghak-hwang
May 25, 2023 16:22
PR #26849: Size comparison from 6dcd58e to 4446ec6 Increases (3 builds for bl602, cyw30739, esp32)
Decreases (2 builds for cc32xx, efr32)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #26849: Size comparison from 964a677 to 9037db0 Increases (8 builds for bl602, cyw30739, psoc6, telink)
Decreases (8 builds for bl702, cc32xx, efr32, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 25, 2023
PR #26849: Size comparison from 49e36af to fc11cf0 Increases (5 builds for cc13x4_26x4, cc32xx, telink)
Decreases (11 builds for bl702, efr32, esp32, k32w, nrfconnect, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
May 26, 2023
yunhanw-google
approved these changes
May 26, 2023
yunhanw-google
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change OptionalQRCodeInfo to data class.
A data class is specifically designed to hold data/state and provide useful methods automatically.
It automatically generates equals(), hashCode(), toString(), and copy() methods based on the primary constructor's properties.