-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin] Add more logging when a device with a matching Matter UUID i… #26832
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Darwin_MoreBleLogging2
May 25, 2023
Merged
[darwin] Add more logging when a device with a matching Matter UUID i… #26832
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Darwin_MoreBleLogging2
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
May 25, 2023 09:21
pullapprove
bot
requested review from
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
vijs,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 25, 2023 09:21
PR #26832: Size comparison from 9f43988 to 03db5a8 Increases (9 builds for bl602, bl702, cyw30739, esp32, psoc6, telink)
Decreases (7 builds for cc32xx, efr32, esp32, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
May 25, 2023
bzbarsky-apple
approved these changes
May 25, 2023
…s discovered over BLE but some parts of the service data does not match
vivien-apple
force-pushed
the
Darwin_MoreBleLogging2
branch
from
May 25, 2023 16:00
03db5a8
to
f4cc3c1
Compare
PR #26832: Size comparison from 4703f74 to f4cc3c1 Increases (7 builds for cyw30739, esp32, nrfconnect, telink)
Decreases (15 builds for bl602, bl702, cc13x4_26x4, cc32xx, efr32, esp32, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s discovered over BLE but some parts of the service data does not match
Problem
This PR adds yet more logging under Darwin when a device with a matching UUID is discovered but does not match the expectations for some other reasons.