Allow building CHIP without lwip checked out #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspang
requested review from
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
rwalker-apple and
saurabhst
as code owners
This used to work prior to project-chip#2325, which added an unconditional dependency on lwip even if we're using sockets. Make it conditional.
mspang
force-pushed
the
for-chip/no-lwip
branch
from
230f012 to
95299a6
Compare
BroderickCarlin
approved these changes
Sep 16, 2020
andy31415
approved these changes
Sep 16, 2020
bzbarsky-apple
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to work prior to #2325, which added an unconditional
dependency on lwip even if we're using sockets. Make it conditional.
Problem
Projects that use CHIP with sockets require an unused lwIP in their checkout.
Summary of Changes
Make the dependency conditional on use of lwIP.