-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Fix MBEDTLS_USE_PSA_CRYPTO not being include for the GSDK build section #26810
Merged
jepenven-silabs
merged 1 commit into
project-chip:master
from
jmartinez-silabs:psa_crypto_define_fix
May 25, 2023
Merged
[Silabs] Fix MBEDTLS_USE_PSA_CRYPTO not being include for the GSDK build section #26810
jepenven-silabs
merged 1 commit into
project-chip:master
from
jmartinez-silabs:psa_crypto_define_fix
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain of define issue that led to MBEDTLS_USE_PSA_CRYPTO not being defined in the GSDK build section
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
May 24, 2023 19:00
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 24, 2023 19:00
PR #26810: Size comparison from bf95967 to 485a429 Increases (10 builds for bl602, bl702, efr32, esp32, psoc6, telink)
Decreases (10 builds for bl602, bl702, cyw30739, esp32, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
May 25, 2023
jepenven-silabs
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a
public_config
in theefr32_mbedtls_config
source set to fix a chain of define issue that led to MBEDTLS_USE_PSA_CRYPTO not being defined in the GSDK build section${chip_root}/src:includes
config definesCHIP_HAVE_CONFIG_H
The absence of this config in the efr32_sdk template led to the following code in
src/platform/silabs/efr32/efr32-chip-mbedtls-config.h
to not defineMBEDTLS_USE_PSA_CRYPTO