-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] MTRDevice should not always send reads to device directly #26776
Merged
bzbarsky-apple
merged 6 commits into
project-chip:master
from
jtung-apple:jtung/darwin-mtrdevice-read-through-fix
May 25, 2023
Merged
[Darwin] MTRDevice should not always send reads to device directly #26776
bzbarsky-apple
merged 6 commits into
project-chip:master
from
jtung-apple:jtung/darwin-mtrdevice-read-through-fix
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
May 24, 2023 01:25
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 24, 2023 01:25
PR #26776: Size comparison from c24294a to 6d3ab6d Increases (9 builds for bl702, nrfconnect, psoc6, telink)
Decreases (10 builds for bl702, cc32xx, efr32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
force-pushed
the
jtung/darwin-mtrdevice-read-through-fix
branch
from
May 24, 2023 19:18
dab4e07
to
7414cc2
Compare
PR #26776: Size comparison from f9731a8 to 7414cc2 Decreases (1 build for nrfconnect)
Full report (4 builds for cc32xx, nrfconnect)
|
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
jtung-apple
force-pushed
the
jtung/darwin-mtrdevice-read-through-fix
branch
from
May 24, 2023 19:41
7414cc2
to
af58c1a
Compare
PR #26776: Size comparison from 9562ce8 to af58c1a Increases (4 builds for bl602, psoc6, telink)
Decreases (12 builds for bl602, bl702, efr32, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 25, 2023
Fast-tracking platform-specific fix with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTRDevice currently sends a read request to the device regardless of whether there's already a cached value. This change reduces this by making it so that the read request is only sent to the device when:
There are a couple of follow-up items that need to be done:
MTRDevice.mm