-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Add more logging related to the cache in src/platform/Darwin… #26748
[Darwin] Add more logging related to the cache in src/platform/Darwin… #26748
Conversation
…/BleConnectionDelegateImpl.mm
PR #26748: Size comparison from 7f6f27d to b54deba Increases (14 builds for bl702, esp32, k32w, psoc6, qpg, telink)
Decreases (7 builds for cc32xx, cyw30739, efr32, esp32, k32w, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, but shouldn't we also log whether we use a thing from cache or not at use time?
There should already be a log line if a thing from the cache is used. |
Ah, the |
…/BleConnectionDelegateImpl.mm
Problem
Under Darwin, this is sometimes hard when debugging to know if the device comes from the cache or not, and if from the cache, what were the advertisement values.