[python] Remove dependency only used in testing #26727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #26727: Size comparison from cbd5dac to 0f87dd6 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Right, missed the essential part 🙈 |
bzbarsky-apple
approved these changes
May 22, 2023
|
PR #26727: Size comparison from cbd5dac to ec5bb29 Increases (6 builds for cc32xx, cyw30739, nrfconnect, telink)
Decreases (13 builds for bl602, bl702, efr32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
May 23, 2023
agners
force-pushed
the
remove-mobly-from-chip-core-deps
branch
from
ec5bb29 to
5b0f9ba
Compare
|
PR #26727: Size comparison from c24294a to 5b0f9ba Increases (7 builds for bl702, nrfconnect, psoc6, telink)
Decreases (13 builds for bl602, bl702, cc32xx, efr32, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
amitnj,
arkq,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
kkasperczyk-no
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
vijs,
xylophone21 and
younghak-hwang
|
Hm, the "Darwin / Build Darwin" build failure looks unrelated to me. Can maybe someone trigger another run? |
|
@agners You need to rebase to tip to fix the Darwin failure... |
agners
force-pushed
the
remove-mobly-from-chip-core-deps
branch
from
250f05c to
442145f
Compare
|
PR #26727: Size comparison from 4b04598 to 442145f Increases (11 builds for cc13x4_26x4, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (15 builds for bl602, bl702, cc13x2_26x2, cc32xx, efr32, k32w, psoc6, qpg, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR project-chip#21567 added mobly as a default dependency of the Python Core CHIP library. The mobly package is only used by the Python testing framework in `src/python_testing/`. Allow to install extra dependency via `script/build_python.sh` flag and install them only when needed.
agners
force-pushed
the
remove-mobly-from-chip-core-deps
branch
from
442145f to
8e14f12
Compare
|
PR #26727: Size comparison from ad5253a to 8e14f12 Increases (5 builds for esp32, nrfconnect, telink)
Decreases (13 builds for bl602, bl702, cc13x4_26x4, cc32xx, efr32, psoc6, qpg, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #21567 added mobly as a default dependency of the Python Core CHIP library. The mobly package is only used by the Python testing framework in
src/python_testing/. Allow to install extra dependency viascript/build_python.shflag and install them only when needed.