-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of if_enabled_clusters #26689
Merged
andy31415
merged 6 commits into
project-chip:master
from
andy31415:remove_if_enabled_clusters
May 19, 2023
Merged
Remove usage of if_enabled_clusters #26689
andy31415
merged 6 commits into
project-chip:master
from
andy31415:remove_if_enabled_clusters
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
May 19, 2023 14:48
pullapprove
bot
requested review from
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 19, 2023 14:48
PR #26689: Size comparison from 243ee4b to 532a901 Increases (1 build for cc32xx)
Decreases (3 builds for bl602, nrfconnect)
Full report (11 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect)
|
bzbarsky-apple
approved these changes
May 19, 2023
PR #26689: Size comparison from 243ee4b to 87de6dc Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26689: Size comparison from 243ee4b to a0d8d95 Full report (2 builds for cc32xx, mbed)
|
PR #26689: Size comparison from 682f348 to 785be9c Decreases (2 builds for bl602, cc32xx)
Full report (14 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect)
|
PR #26689: Size comparison from a271d56 to b9c96b7 Increases (14 builds for bl602, bl702, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for efr32, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loops would already be empty if the clusters are not enabled.
Usage of this macro forces us to have a zap file with enabling, which is inconvenient for client-side code generation where we migrate to using zcl_clusters and similar and ignoring enabling.
These changes move us towards not requiring a zap file for controller codegen.