-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OIS] Set of maintenance improvements and documentation #26688
Merged
bzbarsky-apple
merged 10 commits into
project-chip:master
from
ARM-software:upstream/ois-impr
May 22, 2023
Merged
[OIS] Set of maintenance improvements and documentation #26688
bzbarsky-apple
merged 10 commits into
project-chip:master
from
ARM-software:upstream/ois-impr
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
config
documentation
Improvements or additions to documentation
examples
platform
scripts
test driver
vscode
labels
May 19, 2023
ATmobica
force-pushed
the
upstream/ois-impr
branch
from
May 19, 2023 13:32
594c7c4
to
2c25ad6
Compare
PR #26688: Size comparison from 4752dcc to 2c25ad6 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
ATmobica
force-pushed
the
upstream/ois-impr
branch
from
May 19, 2023 13:50
2c25ad6
to
e363407
Compare
PR #26688: Size comparison from 4752dcc to e363407 Increases (1 build for bl702)
Decreases (3 builds for bl602, bl702)
Full report (11 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect)
|
ATmobica
force-pushed
the
upstream/ois-impr
branch
from
May 19, 2023 14:32
e363407
to
b537282
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248 and
jelderton
May 19, 2023 14:33
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 19, 2023 14:33
PR #26688: Size comparison from 702810d to b537282 Increases (5 builds for bl602, bl702, cc32xx, psoc6)
Decreases (6 builds for efr32, k32w, psoc6)
Full report (42 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamping; did not read details.
andy31415
reviewed
May 19, 2023
andy31415
approved these changes
May 19, 2023
ATmobica
force-pushed
the
upstream/ois-impr
branch
from
May 19, 2023 16:02
b537282
to
08c6b0b
Compare
PR #26688: Size comparison from 682f348 to 08c6b0b Increases (8 builds for esp32, psoc6, telink)
Decreases (12 builds for bl602, cc32xx, efr32, k32w, nrfconnect, psoc6, telink)
Full report (55 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
Cleanup unit-tests project configuration - use default values. Set maximum fabrics to 5 for OIS platform. Cleanup main file. Signed-off-by: ATmobica <[email protected]>
Set Release Cmake build type for non-debug build. Signed-off-by: ATmobica <[email protected]>
Add a Shutdown() function that deinitializes the KV store. Add Shutdown implementation to OIS KV stores. Signed-off-by: ATmobica <[email protected]>
Add build script argument to select KVS storage type ps or tdb. Signed-off-by: ATmobica <[email protected]>
Increase TF-M non-secure partition size to 2.25 MB - adjust to the current size of the binary of examples. Reorder the TF-M memory areas in QSPI. Put the OTP / NV counters between protected storage and ITS. This will be useful for dumping memory to guarantee persistence. Signed-off-by: ATmobica <[email protected]>
Add an option to pass the path to the KVS storage file which will be used to ensure persistence. Use --data and --dump FVP options to load/dump KVS storage memory to the specific file. Add description to the OIS documentation. Signed-off-by: ATmobica <[email protected]>
Use the Linux Fast Models FVP package for Matter environment and install it inside the Docker container. Create helper script to setup FVP Fast Model extension with GDB plugin. Debugging setup documentation update. Signed-off-by: ATmobica <[email protected]>
Create unit test description - setup, build, run, test and debug the unit test project. Explaining the unit testing approach. Add common list of currently supported Matter's component tests. Use it in CMake build, helper script, VSCode tasks and documentation. Update unit tests README file. Signed-off-by: ATmobica <[email protected]>
Add setup Open IoT SDK network VScode task. Add networking setup details and default settings. Update the OIS example documentation and extend it with description of adding a new example. Update examples README files. Create the list of supported Matter examples and use it in helper script and VSCode tasks. Add specific examples of how to build/run/debug and any additional notes to be aware of. Update the OIS commissioning description - use the chip-tool as controller. Co-authored-by: ATmobica <[email protected]> Signed-off-by: Anna Bridge <[email protected]>
Extend platform guides list with OIS documentation items Signed-off-by: ATmobica <[email protected]>
ATmobica
force-pushed
the
upstream/ois-impr
branch
from
May 22, 2023 07:57
08c6b0b
to
b8f95eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config
documentation
Improvements or additions to documentation
examples
platform
review - approved
scripts
test driver
vscode
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve example validation performance in CI.