-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Provision to use the ESP32H2 ECDSA Peripheral #26655
Merged
andy31415
merged 7 commits into
project-chip:master
from
shubhamdp:esp32h2_secure_element
May 23, 2023
Merged
[ESP32] Provision to use the ESP32H2 ECDSA Peripheral #26655
andy31415
merged 7 commits into
project-chip:master
from
shubhamdp:esp32h2_secure_element
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
May 18, 2023 12:51
PR #26655: Size comparison from ca83f16 to e7b428a Increases (6 builds for esp32, psoc6, telink)
Decreases (5 builds for bl702, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
force-pushed
the
esp32h2_secure_element
branch
from
May 18, 2023 15:40
e7b428a
to
901211a
Compare
PR #26655: Size comparison from e230ee1 to 901211a Increases (8 builds for bl602, bl702, cc32xx, psoc6, telink)
Decreases (14 builds for bl702, efr32, esp32, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
force-pushed
the
esp32h2_secure_element
branch
from
May 19, 2023 07:21
901211a
to
52527a1
Compare
PR #26655: Size comparison from e75e729 to 52527a1 Increases (11 builds for bl602, bl702, cc32xx, k32w, psoc6, telink)
Decreases (8 builds for efr32, esp32, nrfconnect, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
force-pushed
the
esp32h2_secure_element
branch
from
May 20, 2023 08:21
52527a1
to
c4a7d74
Compare
PR #26655: Size comparison from bfa0580 to c4a7d74 Increases (11 builds for bl602, bl702, psoc6, telink)
Decreases (4 builds for efr32, esp32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
changed the title
[ESP32] Provision to use the ESP32H2 secure element
[ESP32] Provision to use the ESP32H2 ECDSA Peripheral
May 22, 2023
chshu
reviewed
May 23, 2023
Co-authored-by: Shu Chen <[email protected]>
chshu
approved these changes
May 23, 2023
bzbarsky-apple
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More or less rubber-stamping.
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
May 24, 2023
…6655) * Provision to use the ESP32H2 secure element * Restyled by clang-format * Select the depedent options if soc supports ecdsa peripheral and dac are stored in secure cert * Update src/platform/ESP32/ESP32SecureCertDACProvider.cpp Co-authored-by: Shu Chen <[email protected]> * Make the config option visible * use CONFIG_USE_ECDSA_PERIPHERAL config option than SOC_ECDSA_SUPPORTED * guard the code which is not required when using ecdsa peripheral --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Shu Chen <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
May 24, 2023
* Provision to use the ESP32H2 secure element * Restyled by clang-format * Select the depedent options if soc supports ecdsa peripheral and dac are stored in secure cert * Update src/platform/ESP32/ESP32SecureCertDACProvider.cpp * Make the config option visible * use CONFIG_USE_ECDSA_PERIPHERAL config option than SOC_ECDSA_SUPPORTED * guard the code which is not required when using ecdsa peripheral --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Shu Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
P256Keypair
class and and overloadedInitialize()
and overrodeECDSA_sign_msg()
methods for using ECDSA peripheral.Tests
CONFIG_SEC_CERT_DAC_PROVIDER
and disableCONFIG_ESP_SECURE_CERT_DS_PERIPHERAL
.Follow up work