-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs]Add fallback test value for mandatory attributes VendorName and Produ… #26642
Merged
jmartinez-silabs
merged 3 commits into
project-chip:master
from
jmartinez-silabs:add_basic_info_fallback
May 19, 2023
Merged
[Silabs]Add fallback test value for mandatory attributes VendorName and Produ… #26642
jmartinez-silabs
merged 3 commits into
project-chip:master
from
jmartinez-silabs:add_basic_info_fallback
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
May 17, 2023 22:07
pullapprove
bot
requested review from
msandstedt,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 17, 2023 22:07
PR #26642: Size comparison from c2e12e6 to f9d2788 Increases (14 builds for cc32xx, efr32, nrfconnect, psoc6, telink)
Decreases (9 builds for bl702, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26642: Size comparison from c2e12e6 to 91c55d8 Increases above 0.2%:
Increases (19 builds for bl702, cc32xx, linux, nrfconnect, psoc6)
Decreases (5 builds for bl602, bl702, nrfconnect)
Full report (36 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #26642: Size comparison from c2e12e6 to 66f2d79 Increases above 0.2%:
Increases (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for bl702)
Full report (55 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
bzbarsky-apple
approved these changes
May 18, 2023
…der so it reconize the function within the namespace
jmartinez-silabs
force-pushed
the
add_basic_info_fallback
branch
from
May 18, 2023 17:36
66f2d79
to
2d92dc9
Compare
PR #26642: Size comparison from 293c32d to 2d92dc9 Increases (14 builds for bl602, cc32xx, efr32, esp32, k32w, psoc6, telink)
Decreases (9 builds for cyw30739, esp32, nrfconnect, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctName
fixes #26267
also update the
sl_matter_version_str
prefix to v1.1