-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zcl_clusters
to loop over clusters for controller_clusters.zap
#26617
Merged
andy31415
merged 20 commits into
project-chip:master
from
andy31415:matter_client_use_zcl_clusters
May 18, 2023
Merged
Use zcl_clusters
to loop over clusters for controller_clusters.zap
#26617
andy31415
merged 20 commits into
project-chip:master
from
andy31415:matter_client_use_zcl_clusters
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26617: Size comparison from 7a2dd22 to 117505f Increases (4 builds for linux, psoc6, qpg)
Decreases (7 builds for bl602, bl702, cc32xx, psoc6)
Full report (36 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, psoc6, qpg)
|
PR #26617: Size comparison from 64bf867 to 4a0d257 Increases (9 builds for bl702, efr32, linux, psoc6, telink)
Decreases (6 builds for bl602, telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26617: Size comparison from 64bf867 to 546f5ba Increases (8 builds for bl702, efr32, linux, psoc6, telink)
Decreases (10 builds for bl602, cc32xx, cyw30739, telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26617: Size comparison from 21ef744 to eeea706 Increases (7 builds for cc32xx, linux, nrfconnect, telink)
Decreases (11 builds for bl602, bl702, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that .matter files for client side does NOT care about cluster enabling/disabling.
Changes:
ClusterBase
instead of named clusters fromCHIPClusters
(as CHIPClusters seem a bit useless ... just aliases really)