-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of certificate validity policy in CHIPDeviceControllerFactory. (v1.1 cherry-pick of PR 26526) #26545
Merged
andy31415
merged 1 commit into
project-chip:v1.1-branch
from
bzbarsky-apple:cherrypick-10af55d07490f84d6d6ac4396008fe031a893723
May 12, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory. (project-chip#26526) When we created a new system state, we lost track of the certificate validity policy (since it's not stored in the system state and was not copied from the old one to the new one). Just store it in the controller factory like other things of that sort, so we make sure to propagate it to all system states.
bzbarsky-apple
deleted the
cherrypick-10af55d07490f84d6d6ac4396008fe031a893723
branch
May 12, 2023 14:34
PR #26545: Size comparison from 48781a6 to 83bbed2 Increases (9 builds for bl702, linux, psoc6, telink)
Decreases (13 builds for cc32xx, efr32, nrfconnect, psoc6, telink)
Full report (64 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #26526 to the v1.1 branch.
When we created a new system state, we lost track of the certificate validity policy (since it's not stored in the system state and was not copied from the old one to the new one).
Just store it in the controller factory like other things of that sort, so we make sure to propagate it to all system states.