Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Second take to fix bloat check #26544

Merged
merged 1 commit into from
May 12, 2023

Conversation

Damian-Nordic
Copy link
Contributor

@Damian-Nordic Damian-Nordic commented May 12, 2023

In the previous PR (#26479) I replaced the deprecated DataFrame.append with pandas.concat, but I didn't realize that our memory scripts add extra attributes to the data frame object, which are not copied during the concatenation.

This time, I verified the script locally using --github-comment and --github-dryrun-comment to test the code for preparing the PR comments.

Also, do not fetch submodules in the bloat check job as it takes most of the job's execution time.

Apparently, in the previous PR I replaced the deprecated
DataFrame.append with pandas.concat, but I didn't realize
that our scripts add extra attributes to the data frame,
which are not copied during the concatenation.

This time, I verified the script locally using
--github-comment and --github-dryrun-comment.

Also, do not fetch submodules in the bloat check job as
it takes most of the job's execution time.
@github-actions
Copy link

PR #26544: Size comparison from a3b4005 to 9074d6f

Full report (1 build for cc32xx)
platform target config section a3b4005 9074d6f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605018 605018 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 958615 958615 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342084 342084 0 0.0
.debug_info 19678442 19678442 0 0.0
.debug_line 2673606 2673606 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491157 1491157 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131974 3131974 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104322 104322 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483172 483172 0 0.0
.symtab 287232 287232 0 0.0
.text 498572 498572 0 0.0

@andy31415 andy31415 merged commit 176b0e4 into project-chip:master May 12, 2023
@Damian-Nordic Damian-Nordic deleted the bloat-check-2 branch May 12, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants