ESP32: avoid installing gdbgui when not needed #26542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESP-IDF v4.4.4 requires gdbgui only when Python before 3.11 is used (see espressif/esp-idf@3974be7). Avoid installing it when not needed. Fixes: project-chip#25385
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #26542: Size comparison from a3b4005 to 087a555 Increases (2 builds for bl602, cc32xx)
Decreases (4 builds for bl702, nrfconnect, qpg)
Full report (16 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
andy31415
approved these changes
May 12, 2023
shubhamdp
pushed a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Aug 3, 2023
ESP-IDF v4.4.4 requires gdbgui only when Python before 3.11 is used (see espressif/esp-idf@3974be7). Avoid installing it when not needed. Fixes: project-chip#25385
shubhamdp
pushed a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Aug 4, 2023
ESP-IDF v4.4.4 requires gdbgui only when Python before 3.11 is used (see espressif/esp-idf@3974be7). Avoid installing it when not needed. Fixes: project-chip#25385
andy31415
added a commit
that referenced
this pull request
Aug 8, 2023
* ESP32: avoid installing gdbgui when not needed (#26542) ESP-IDF v4.4.4 requires gdbgui only when Python before 3.11 is used (see espressif/esp-idf@3974be7). Avoid installing it when not needed. Fixes: #25385 * Remove gdbgui requirement for esp32 (#28007) * Remove gdbgui requirement for esp32 * Fix qemu * Fix chef as well --------- Co-authored-by: Stefan Agner <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
ankk-css
pushed a commit
to ying-css/connectedhomeip
that referenced
this pull request
Aug 8, 2023
…t-chip#28507) * ESP32: avoid installing gdbgui when not needed (project-chip#26542) ESP-IDF v4.4.4 requires gdbgui only when Python before 3.11 is used (see espressif/esp-idf@3974be7). Avoid installing it when not needed. Fixes: project-chip#25385 * Remove gdbgui requirement for esp32 (project-chip#28007) * Remove gdbgui requirement for esp32 * Fix qemu * Fix chef as well --------- Co-authored-by: Stefan Agner <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
andy31415
added a commit
that referenced
this pull request
Aug 25, 2023
#28397) * Added support for Optiga Trust M. * * Added no warning flag when applying patch for optiga-trust-m. * Add the optiga_lib_config_mtb.h * 1)Updated README.md for psoc6 lock-app example 2)Added infineon_trustm_provisioning.md * 1)Updated README.md for psoc6 lock-app * 1)Updated README.md for psoc6 lock-app * 1)Updated optiga-trust-m submodule 2)Updated README.md for psoc6 lock-app * 1)Updated DeviceAttestationCredsExampleTrustM.cpp 2)Updated the argument with infineon added * 1)Updated CHIPCryptoPALHsm_HKDF_trustm.cpp and CHIPCryptoPALHsm_HMAC_trustm.cpp * Merging with v1.1-branch * Resolve merge conflicts with v1.1-branch * * Updated the copyright dates. * Updated README. * Removed PersistentStorage File. * 1)Changes to enable build door-lock example with Trust M using python script 2)Fixed the bug for CHIPCryptoPALHsm_HMAC_trustm.cpp * Restyled by whitespace * Restyled by clang-format * [Cherrypick] CI: Fix for v1.1-branch CI, broken due to gdbgui (#28507) * ESP32: avoid installing gdbgui when not needed (#26542) ESP-IDF v4.4.4 requires gdbgui only when Python before 3.11 is used (see espressif/esp-idf@3974be7). Avoid installing it when not needed. Fixes: #25385 * Remove gdbgui requirement for esp32 (#28007) * Remove gdbgui requirement for esp32 * Fix qemu * Fix chef as well --------- Co-authored-by: Stefan Agner <[email protected]> Co-authored-by: Andrei Litvin <[email protected]> * Fix CI/CD issues: - Misspell - restyling - infineon build * Resolve CI/CD Build issues for "Build on Linux" --------- Co-authored-by: Ank Khandelwal <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Shubham Patil <[email protected]> Co-authored-by: Stefan Agner <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-IDF v4.4.4 requires gdbgui only when Python before 3.11 is used (see espressif/esp-idf@3974be7). Avoid installing it when not needed. This allows to boostrap the SDK on systems with Python 3.11.
Fixes: #25385