Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chiptool.py] Make sure to update the exit code properly if parsing f… #26539

Merged
merged 1 commit into from
May 12, 2023
Merged

[chiptool.py] Make sure to update the exit code properly if parsing f… #26539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/py_matter_yamltests/matter_yamltests/parser_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def __init__(self, config: TestParserBuilderConfig = TestParserBuilderConfig()):
self.__tests = copy.copy(config.tests)
self.__config = config
self.__duration = 0
self.__done = False
self.done = False

def __iter__(self):
self.__config.hooks.start(len(self.__tests))
Expand All @@ -76,9 +76,9 @@ def __next__(self):
if len(self.__tests):
return self.__get_test_parser(self.__tests.pop(0))

if not self.__done:
if not self.done:
self.__config.hooks.stop(round(self.__duration))
self.__done = True
self.done = True

raise StopIteration

Expand Down
2 changes: 1 addition & 1 deletion scripts/py_matter_yamltests/matter_yamltests/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def run(self, parser_builder_config: TestParserBuilderConfig, runner_config: Tes
duration = round((time.time() - start) * 1000)
runner_config.hooks.stop(duration)

return True
return parser_builder.done

async def _run(self, parser: TestParser, config: TestRunnerConfig):
status = True
Expand Down