-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Json to Tlv and Tlv to Json Converter in Kotlin #26527
Merged
andy31415
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/kotlin-json-to-tlv-to-json-converter_v2
May 16, 2023
Merged
Implemented Json to Tlv and Tlv to Json Converter in Kotlin #26527
andy31415
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/kotlin-json-to-tlv-to-json-converter_v2
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26527: Size comparison from 305c026 to f701f75 Full report (3 builds for cc32xx, qpg)
|
emargolis
force-pushed
the
emargolis/feature/kotlin-json-to-tlv-to-json-converter_v2
branch
from
May 12, 2023 05:43
f701f75
to
248272e
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
May 12, 2023 05:44
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 12, 2023 05:44
PR #26527: Size comparison from a3b4005 to 248272e Full report (1 build for cc32xx)
|
andy31415
previously approved these changes
May 12, 2023
andy31415
dismissed
their stale review
May 12, 2023 17:13
Removing checkmark - did not notice that this bundles json into tlv ... I think they should be distinct.
andy31415
reviewed
May 12, 2023
Note that NOT all TLV configurations are supported by the current implementation. Here is the list of limitations: - TLV Lists are not supported - Multi-Dimensional TLV Arrays are not supported - All elements of an array MUST be of the same type - The top level TLV element MUST be a single structure with AnonymousTag - The following tags are supported: - AnonymousTag are used only with TLV Arrays elements or a top-level structure - ContextSpecificTag are used only with TLV Structure elements - CommonProfileTag are used only with TLV Structure elements - Infinity Float/Double values are not supported
emargolis
force-pushed
the
emargolis/feature/kotlin-json-to-tlv-to-json-converter_v2
branch
from
May 15, 2023 18:13
248272e
to
c3a6310
Compare
PR #26527: Size comparison from b4fb147 to c3a6310 Increases (12 builds for bl602, bl702, psoc6, telink)
Decreases (9 builds for cyw30739, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
May 16, 2023
tianfeng-yang
pushed a commit
to tianfeng-yang/connectedhomeip
that referenced
this pull request
May 17, 2023
…chip#26527) Note that NOT all TLV configurations are supported by the current implementation. Here is the list of limitations: - TLV Lists are not supported - Multi-Dimensional TLV Arrays are not supported - All elements of an array MUST be of the same type - The top level TLV element MUST be a single structure with AnonymousTag - The following tags are supported: - AnonymousTag are used only with TLV Arrays elements or a top-level structure - ContextSpecificTag are used only with TLV Structure elements - CommonProfileTag are used only with TLV Structure elements - Infinity Float/Double values are not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that NOT all TLV configurations are supported by the current implementation. Here is the list of limitations: