Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the "ignore certificate validity dates" policy out of Server.h. #26519

Merged
merged 1 commit into from
May 11, 2023
Merged

Move the "ignore certificate validity dates" policy out of Server.h. #26519

merged 1 commit into from
May 11, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This makes it easier to use for clients that don't have reliable wall-clock time.

@github-actions
Copy link

PR #26519: Size comparison from ac16417 to 5e1dd50

Increases (1 build for cc32xx)
platform target config section ac16417 5e1dd50f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 957619 958615 996 0.1
.debug_info 19674626 19678194 3568 0.0
.debug_line 2671903 2673606 1703 0.1
.debug_loclists 1491139 1491157 18 0.0
.debug_str 3131828 3131974 146 0.0
.strtab 483089 483172 83 0.0
Full report (1 build for cc32xx)
platform target config section ac16417 5e1dd50f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 958615 996 0.1
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674626 19678194 3568 0.0
.debug_line 2671903 2673606 1703 0.1
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491157 18 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131974 146 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483172 83 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the move-validity-policy branch from 5e1dd50 to b6f2401 Compare May 11, 2023 19:00
@github-actions
Copy link

PR #26519: Size comparison from ac16417 to b6f2401

Increases (1 build for cc32xx)
platform target config section ac16417 b6f2401 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 957619 958615 996 0.1
.debug_info 19674626 19678193 3567 0.0
.debug_line 2671903 2673606 1703 0.1
.debug_loclists 1491139 1491157 18 0.0
.debug_str 3131828 3131974 146 0.0
.strtab 483089 483172 83 0.0
Full report (1 build for cc32xx)
platform target config section ac16417 b6f2401 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 958615 996 0.1
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674626 19678193 3567 0.0
.debug_line 2671903 2673606 1703 0.1
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491157 18 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131974 146 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483172 83 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0

@bzbarsky-apple
Move the "ignore certificate validity dates" policy out of Server.h.
6c84674 
This makes it easier to use for clients that don't have reliable wall-clock
time.
@bzbarsky-apple bzbarsky-apple force-pushed the move-validity-policy branch from b6f2401 to 6c84674 Compare May 11, 2023 19:55
@github-actions
Copy link

PR #26519: Size comparison from ac16417 to 6c84674

Increases (1 build for cc32xx)
platform target config section ac16417 6c84674 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 957619 958615 996 0.1
.debug_info 19674626 19678194 3568 0.0
.debug_line 2671903 2673606 1703 0.1
.debug_loclists 1491139 1491157 18 0.0
.debug_str 3131828 3131974 146 0.0
.strtab 483089 483172 83 0.0
Full report (1 build for cc32xx)
platform target config section ac16417 6c84674 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 958615 996 0.1
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674626 19678194 3568 0.0
.debug_line 2671903 2673606 1703 0.1
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491157 18 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131974 146 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483172 83 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit ee8d535 into project-chip:master May 11, 2023
@bzbarsky-apple bzbarsky-apple deleted the move-validity-policy branch May 11, 2023 23:57
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request May 12, 2023
@bzbarsky-apple
Move the "ignore certificate validity dates" policy out of Server.h. (p…
7485b11 
…roject-chip#26519)

This makes it easier to use for clients that don't have reliable wall-clock
time.
@bzbarsky-apple bzbarsky-apple mentioned this pull request May 12, 2023
Merged
andy31415 pushed a commit that referenced this pull request May 12, 2023
@bzbarsky-apple
Move the "ignore certificate validity dates" policy out of Server.h. (#…
48781a6 
…26519) (#26528)

This makes it easier to use for clients that don't have reliable wall-clock
time.
maciejbaczmanski pushed a commit to maciejbaczmanski/connectedhomeip that referenced this pull request Jul 15, 2024
@bzbarsky-apple @markaj-nordic
[nrf fromtree] Move the "ignore certificate validity dates" policy ou…
640c479 
…t of Server.h. (project-chip#26519)

This makes it easier to use for clients that don't have reliable wall-clock
time.
maciejbaczmanski pushed a commit to maciejbaczmanski/connectedhomeip that referenced this pull request Jul 15, 2024
@kkasperczyk-no
Revert "[nrf fromtree] Move the "ignore certificate validity dates" p…
b679abc 
…olicy out of Server.h. (project-chip#26519)"

This reverts commit 640c479.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@tehampson tehampson tehampson approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app cherry picked to 1.1 examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @tehampson @woody-apple @jmartinez-silabs @andy31415