Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make slightly better use of SockAddr in TCP code. #26483

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Since we have a union for our type-punning, we don't need to do reinterpret_cast.

@github-actions
Copy link

PR #26483: Size comparison from ce307eb to b28ea2f

Decreases (1 build for cc32xx)
platform target config section ce307eb b28ea2f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19674627 19674626 -1 -0.0
Full report (1 build for cc32xx)
platform target config section ce307eb b28ea2f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674627 19674626 -1 -0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0

Since we have a union for our type-punning, we don't need to do
reinterpret_cast.
@bzbarsky-apple bzbarsky-apple force-pushed the tcp-use-SockAddr-better branch from b28ea2f to 3e78531 Compare May 11, 2023 00:27
@bzbarsky-apple bzbarsky-apple merged commit bb3ce44 into project-chip:master May 11, 2023
@bzbarsky-apple bzbarsky-apple deleted the tcp-use-SockAddr-better branch May 11, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants