Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Fix build with non-default toolchain #26475

Merged
merged 3 commits into from
May 10, 2023

Conversation

arkq
Copy link
Contributor

@arkq arkq commented May 10, 2023

Problem

Tizen GN SDK does not work properly in case when non-default GN toolchain is used.

Changes

  • fix GN SDK for Tizen
  • do not add tizen:check to the default check target in case when BLE is enabled. Currently, Tizen QEMU-based tests do not support Bluetooth.

Testing

Tested locally with:

gn gen out/check --args="target_os=\"all\" tizen_sdk_root=\"$TIZEN_SDK_ROOT\" tizen_sdk_sysroot=\"$TIZEN_SDK_SYSROOT\" enable_tizen_builds=true"
ninja -C out/check check

gn gen out/check --args="target_os=\"all\" tizen_sdk_root=\"$TIZEN_SDK_ROOT\" tizen_sdk_sysroot=\"$TIZEN_SDK_SYSROOT\" enable_tizen_builds=true chip_config_network_layer_ble=false"
ninja -C out/check check

CI will check the rest.

@github-actions
Copy link

PR #26475: Size comparison from 4f081a5 to 0c826f1

Full report (1 build for cc32xx)
platform target config section 4f081a5 0c826f1 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674626 19674626 0 0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0

@andy31415 andy31415 merged commit 447b9ec into project-chip:master May 10, 2023
@arkq arkq deleted the tizen-gn-sdk-fix branch May 10, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants