-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster definition for smoke-co-alarm #26474
Conversation
PR #26474: Size comparison from 4f081a5 to cca64af Increases above 0.2%:
Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26474: Size comparison from cfb9994 to 1ba889e Increases (5 builds for bl602, telink)
Decreases (15 builds for bl702, cc13x4_26x4, efr32, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@bzbarsky-apple I've modified them, added documentation to the headers, and submitted a spec issue. |
PR #26474: Size comparison from cfb9994 to 44f1842 Increases (3 builds for bl602, cc13x4_26x4, telink)
Decreases (16 builds for bl702, cc13x2_26x2, cc13x4_26x4, efr32, esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Smoke/CO: Update README.md Smoke/CO: Update README.md
Restyled by clang-format Smoke/CO: Fix spelling and documentation Smoke/CO: Trigger interconnect alarm on warning Smoke/CO: Update smoke-co-alarm-app.zap * Change some attributes to NVM * regen zap
PR #26474: Size comparison from 2377844 to 65e408e Increases (12 builds for bl602, bl702, cyw30739, esp32, psoc6, telink)
Decreases (7 builds for bl602, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@bzbarsky-apple I have revised the conflicting content, please review, thanks. |
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
* Remove unused define * Add comments * Call SelfTestRequest function directly * Add static_assert * Change to server is responsible for setting ExpressedState
PR #26474: Size comparison from 68621d0 to 328c235 Increases (11 builds for bl602, bl702, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, cc32xx, esp32, k32w, nrfconnect, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
PR #26474: Size comparison from 43cfe21 to 34e711b Increases (6 builds for bl602, psoc6, telink)
Decreases (11 builds for bl602, bl702, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26474: Size comparison from dad733c to 002cae3 Increases (9 builds for bl602, cc32xx, efr32, esp32, psoc6, telink)
Decreases (9 builds for bl702, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This PR adds an implementation of a Smoke CO Alarm.