Inet implementations assume BYTE_ORDER is defined. make sure that it is #26460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #26460: Size comparison from 7b5ecb2 to 58d9277 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
reviewed
May 10, 2023
andy31415
reviewed
May 10, 2023
|
PR #26460: Size comparison from 7b5ecb2 to 7d09a84 Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
May 10, 2023
arkq
approved these changes
May 10, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #26460: Size comparison from 7b5ecb2 to 114800e Increases (4 builds for cc13x2_26x2, k32w, nrfconnect, qpg)
Decreases (3 builds for bl602, cc13x2_26x2)
Full report (23 builds for bl602, bl702, cc13x2_26x2, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
jmartinez-silabs
added a commit
to jmartinez-silabs/connectedhomeip
that referenced
this pull request
May 16, 2023
…is (project-chip#26460) * BYTE_ORDER must be defined in the project * fix typo * Remove BYTE_ORDER from the file. Only use __BYTE_ORDER__ and relative checks * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
May 16, 2023
…is (#26460) (#26615) * BYTE_ORDER must be defined in the project * fix typo * Remove BYTE_ORDER from the file. Only use __BYTE_ORDER__ and relative checks * Apply suggestions from code review --------- Co-authored-by: Boris Zbarsky <[email protected]>
jmartinez-silabs
added a commit
to SiliconLabs/matter
that referenced
this pull request
May 18, 2023
… is defined. make sure that it is (project-chip#26460) Merge in WMN_TOOLS/matter from cherry-pick/Fix_multicast_addr_endianness to RC_2.0.0-1.1 Squashed commit of the following: commit 50f8a0590cfbfb2c0d69798efb641c4d4de1a7c2 Author: Junior Martinez <[email protected]> Date: Wed May 10 09:24:21 2023 -0400 Inet implementations assume BYTE_ORDER is defined. make sure that it is (project-chip#26460) * BYTE_ORDER must be defined in the project * fix typo * Remove BYTE_ORDER from the file. Only use __BYTE_ORDER__ and relative checks * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BYTE_ORDER was not defined in Silabs Thread apps. But the inet implementation assumes it is for some endianness conversion.
Recent changes to GCC highlighted this missing define as we were now using the big-endian implementation of
hotnlon the Silabs platform due to#if BYTE_ORDER == BIG_ENDIANevaluating to true when both of the defines didn't exist.This, ultimately, led to
IPAddress::IPAddress::MakeIPv6Multicastreturning an invalid Multicast address.Anyhow, this PR adds some checks on the existence of the BYTE_ORDER defined.
for
CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINTinet implementation, Try at least to define BYTE_ORDER to the right endianness of the system if the definition doesn't exist already.Note: Platforms using
lwipusually defineBYTE_ORDER,BIG_ENDIAN,LITTLE_ENDIANinarch/cc.h