Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qpg: build libFactoryData instead of using an artifact #26449

Merged

Conversation

q-thla
Copy link
Contributor

@q-thla q-thla commented May 9, 2023

Instead of using a static factory data blob, use a freshly build libfactorydata.a so any changes to .factory_data_config file or its input files are picked up by the GN build.

Instead of using a static factory data blob, use a freshly build
libfactorydata.a so any changes to .factory_data_config file or its
input files are picked up by the GN build.
@github-actions
Copy link

github-actions bot commented May 9, 2023

PR #26449: Size comparison from 7bbd64d to 8c41e67

Decreases (3 builds for bl602, bl702, cc32xx)
platform target config section 7bbd64d 8c41e67 change % change
bl602 lighting-app bl602+rpc .text 1067334 1067332 -2 -0.0
bl702 lighting-app bl702 .debug_info 40943089 40943088 -1 -0.0
.text 965472 965470 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19674627 19674626 -1 -0.0
Full report (5 builds for bl602, bl702, cc32xx)
platform target config section 7bbd64d 8c41e67 change % change
bl602 lighting-app bl602 (read/write) 1354998 1354998 0 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1035978 1035978 0 0.0
bl602+rpc (read/write) 1401266 1401266 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067334 1067332 -2 -0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1185759 1185759 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1550204 1550204 0 0.0
.debug_aranges 132944 132944 0 0.0
.debug_frame 488804 488804 0 0.0
.debug_info 40943089 40943088 -1 -0.0
.debug_line 5301455 5301455 0 0.0
.debug_loc 3424613 3424613 0 0.0
.debug_ranges 372344 372344 0 0.0
.debug_str 3708223 3708223 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106304 106304 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580786 580786 0 0.0
.symtab 175264 175264 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 965472 965470 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1273555 1273555 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1706954 1706954 0 0.0
.debug_aranges 141224 141224 0 0.0
.debug_frame 516776 516776 0 0.0
.debug_info 45848902 45848902 0 0.0
.debug_line 5716360 5716360 0 0.0
.debug_loc 3626917 3626917 0 0.0
.debug_ranges 397648 397648 0 0.0
.debug_str 4133328 4133328 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120144 120144 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641456 641456 0 0.0
.symtab 193600 193600 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1038096 1038096 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674627 19674626 -1 -0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants