Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs]- Adds fix for LastConnectErrorValue have null after device reset #26448

Merged
merged 2 commits into from
May 9, 2023
Merged

[Silabs]- Adds fix for LastConnectErrorValue have null after device reset #26448

merged 2 commits into from
May 9, 2023

Conversation

LeelakumarPS
Copy link
Contributor

  • Adds fix for LastConnectErrorValue have null after device reset
  • Tested manually

@LeelakumarPS LeelakumarPS force-pushed the bugfix/Wifi_populate_LastConnectErrorValue branch from de095e3 to fc2e126 Compare May 9, 2023 12:56
@github-actions
Copy link

github-actions bot commented May 9, 2023

PR #26448: Size comparison from 38466c2 to c1e25cd

Full report (1 build for cc32xx)
platform target config section 38466c2 c1e25cd change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674626 19674626 0 0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0

@LeelakumarPS LeelakumarPS force-pushed the bugfix/Wifi_populate_LastConnectErrorValue branch from c1e25cd to 2c671f6 Compare May 9, 2023 13:29
@andy31415
Copy link
Contributor

@LeelakumarPS could you expand the summary to explain what the issue was and what the fix is?

Looking at the delta I see this changed MakeOptional((int32_t) SL_STATUS_FAIL) to NullOptional. Why was the old value wrong, why is the new value good?

As a reviewer I lack some context here.

@github-actions
Copy link

github-actions bot commented May 9, 2023

PR #26448: Size comparison from 7e69af7 to 2c671f6

Increases (4 builds for bl602, cyw30739, psoc6)
platform target config section 7e69af7 2c671f6 change % change
bl602 lighting-app bl602+rpc .text 1067332 1067334 2 0.0
cyw30739 ota-requestor cyw930739m2evb_01 (read/write) 566083 566091 8 0.0
.app_xip_area 459637 459645 8 0.0
switch cyw930739m2evb_01 (read/write) 530859 530867 8 0.0
.app_xip_area 421845 421853 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27005207 27005208 1 0.0
Decreases (4 builds for bl602, bl702, cc32xx, psoc6)
platform target config section 7e69af7 2c671f6 change % change
bl602 lighting-app bl602 (read/write) 1354998 1354990 -8 -0.0
.text 1035978 1035976 -2 -0.0
bl702 lighting-app bl702 .debug_info 40943089 40943088 -1 -0.0
.text 965472 965470 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19674628 19674627 -1 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26781330 26781329 -1 -0.0
Full report (25 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, psoc6)
platform target config section 7e69af7 2c671f6 change % change
bl602 lighting-app bl602 (read/write) 1354998 1354990 -8 -0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1035978 1035976 -2 -0.0
bl602+rpc (read/write) 1401266 1401266 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067332 1067334 2 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1185759 1185759 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1550204 1550204 0 0.0
.debug_aranges 132944 132944 0 0.0
.debug_frame 488804 488804 0 0.0
.debug_info 40943089 40943088 -1 -0.0
.debug_line 5301455 5301455 0 0.0
.debug_loc 3424613 3424613 0 0.0
.debug_ranges 372344 372344 0 0.0
.debug_str 3708223 3708223 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106304 106304 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580786 580786 0 0.0
.symtab 175264 175264 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 965472 965470 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1273555 1273555 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1706954 1706954 0 0.0
.debug_aranges 141224 141224 0 0.0
.debug_frame 516776 516776 0 0.0
.debug_info 45848902 45848902 0 0.0
.debug_line 5716360 5716360 0 0.0
.debug_loc 3626917 3626917 0 0.0
.debug_ranges 397648 397648 0 0.0
.debug_str 4133328 4133328 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120144 120144 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641456 641456 0 0.0
.symtab 193600 193600 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1038096 1038096 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678967 678967 0 0.0
(read/write) 158620 158620 0 0.0
.bss 81192 81192 0 0.0
.data 3316 3316 0 0.0
.rodata 86783 86783 0 0.0
.text 591864 591864 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644847 644847 0 0.0
(read/write) 157860 157860 0 0.0
.bss 80432 80432 0 0.0
.data 3316 3316 0 0.0
.rodata 76767 76767 0 0.0
.text 567760 567760 0 0.0
lock-ftd LP_CC2652R7 (read only) 680023 680023 0 0.0
(read/write) 156136 156136 0 0.0
.bss 78744 78744 0 0.0
.data 3280 3280 0 0.0
.rodata 75639 75639 0 0.0
.text 603896 603896 0 0.0
lock-mtd LP_CC2652R7 (read only) 667411 667411 0 0.0
(read/write) 151312 151312 0 0.0
.bss 73920 73920 0 0.0
.data 3280 3280 0 0.0
.rodata 102459 102459 0 0.0
.text 564464 564464 0 0.0
pump-app LP_CC2652R7 (read only) 692619 692619 0 0.0
(read/write) 156588 156588 0 0.0
.bss 78720 78720 0 0.0
.data 3244 3244 0 0.0
.rodata 89755 89755 0 0.0
.text 602376 602376 0 0.0
pump-controller-app LP_CC2652R7 (read only) 678107 678107 0 0.0
(read/write) 157004 157004 0 0.0
.bss 78856 78856 0 0.0
.data 3268 3268 0 0.0
.rodata 85531 85531 0 0.0
.text 592088 592088 0 0.0
shell LP_CC2652R7 (read only) 672166 672166 0 0.0
(read/write) 160692 160692 0 0.0
.bss 83280 83280 0 0.0
.data 3300 3300 0 0.0
.rodata 85078 85078 0 0.0
.text 586764 586764 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674628 19674627 -1 -0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 524275 524275 0 0.0
.app_xip_area 417069 417069 0 0.0
.bss 62184 62184 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 528955 528955 0 0.0
.app_xip_area 416445 416445 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566083 566091 8 0.0
.app_xip_area 459637 459645 8 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 530859 530867 8 0.0
.app_xip_area 421845 421853 8 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read only) 583444 583444 0 0.0
(read/write) 82704 82704 0 0.0
.bss 65888 65888 0 0.0
.data 2192 2192 0 0.0
.text 582908 582908 0 0.0
light k32w0+release (read only) 582300 582300 0 0.0
(read/write) 82356 82356 0 0.0
.bss 65552 65552 0 0.0
.data 2180 2180 0 0.0
.text 581764 581764 0 0.0
lock k32w0+release (read only) 555820 555820 0 0.0
(read/write) 80352 80352 0 0.0
.bss 63624 63624 0 0.0
.data 2104 2104 0 0.0
.text 555284 555284 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12248540 12248540 0 0.0
(read/write) 746680 746680 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 688336 688336 0 0.0
.dynamic 560 560 0 0.0
.got 15752 15752 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 569424 569424 0 0.0
.text 9906500 9906500 0 0.0
thermostat-no-ble arm64 (read only) 2525028 2525028 0 0.0
(read/write) 145768 145768 0 0.0
.bss 56392 56392 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 78048 78048 0 0.0
.dynamic 560 560 0 0.0
.got 5456 5456 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 129848 129848 0 0.0
.text 2130960 2130960 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840680 840680 0 0.0
(read/write) 1706636 1706636 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190108 190108 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1283658 1283658 0 0.0
.debug_aranges 128296 128296 0 0.0
.debug_frame 425808 425808 0 0.0
.debug_info 27005207 27005208 1 0.0
.debug_line 3758736 3758736 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2021774 2021774 0 0.0
.debug_rnglists 128096 128096 0 0.0
.debug_str 3640134 3640134 0 0.0
.heap 840680 840680 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 716171 716171 0 0.0
.symtab 466336 466336 0 0.0
.text 1505588 1505588 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841440 841440 0 0.0
(read/write) 1648948 1648948 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189348 189348 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1278486 1278486 0 0.0
.debug_aranges 127768 127768 0 0.0
.debug_frame 428876 428876 0 0.0
.debug_info 26781330 26781329 -1 -0.0
.debug_line 3781468 3781468 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2014868 2014868 0 0.0
.debug_rnglists 127260 127260 0 0.0
.debug_str 3631836 3631836 0 0.0
.heap 841440 841440 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 674859 674859 0 0.0
.symtab 451648 451648 0 0.0
.text 1448660 1448660 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849736 849736 0 0.0
(read/write) 1570588 1570588 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181220 181220 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2384 2384 0 0.0
.debug_abbrev 1111492 1111492 0 0.0
.debug_aranges 117920 117920 0 0.0
.debug_frame 392112 392112 0 0.0
.debug_info 22304613 22304613 0 0.0
.debug_line 3345359 3345359 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1846382 1846382 0 0.0
.debug_rnglists 116889 116889 0 0.0
.debug_str 3437815 3437815 0 0.0
.heap 849736 849736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 590912 590912 0 0.0
.symtab 414096 414096 0 0.0
.text 1378596 1378596 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 821952 821952 0 0.0
(read/write) 1627076 1627076 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208996 208996 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1110480 1110480 0 0.0
.debug_aranges 118424 118424 0 0.0
.debug_frame 394204 394204 0 0.0
.debug_info 22484512 22484512 0 0.0
.debug_line 3341745 3341745 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1859809 1859809 0 0.0
.debug_rnglists 117345 117345 0 0.0
.debug_str 3452797 3452797 0 0.0
.heap 821952 821952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 594913 594913 0 0.0
.symtab 416400 416400 0 0.0
.text 1407300 1407300 0 0.0
.zero.table 8 8 0 0.0

@yufengwangca yufengwangca merged commit 437260f into project-chip:master May 9, 2023
@LeelakumarPS LeelakumarPS changed the title Adds fix for LastConnectErrorValue have null after device reset [Silabs]- Adds fix for LastConnectErrorValue have null after device reset May 10, 2023
rosahay-silabs
rosahay-silabs reviewed May 15, 2023
View reviewed changes
src/platform/silabs/NetworkCommissioningWiFiDriver.cpp
@@ -179,12 +179,10 @@ void SlWiFiDriver::UpdateNetworkingStatus()
ByteSpan networkId = ByteSpan((const unsigned char *) mStagingNetwork.ssid, mStagingNetwork.ssidLen);
if (!wfx_is_sta_connected())
{
mpStatusChangeCallback->OnNetworkingStatusChange(Status::kUnknownError, MakeOptional(networkId),
MakeOptional((int32_t) SL_STATUS_FAIL));
mpStatusChangeCallback->OnNetworkingStatusChange(Status::kUnknownError, MakeOptional(networkId), NullOptional);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosahay-silabs rosahay-silabs rosahay-silabs left review comments

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LeelakumarPS @andy31415 @yufengwangca @woody-apple @rosahay-silabs @restyled-commits