Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qpg: move to mbedtls v3.3 hosted by third_party/qpg_sdk/repo #26416

Merged
merged 1 commit into from
May 9, 2023
Merged

qpg: move to mbedtls v3.3 hosted by third_party/qpg_sdk/repo #26416

merged 1 commit into from
May 9, 2023

Conversation

q-thla
Copy link
Contributor

@q-thla q-thla commented May 8, 2023 •
edited
Loading

qpg: move to mbedtls v3.3 hosted by third_party/qpg_sdk/repo

This enables us to use PSA crypto.

@q-thla q-thla force-pushed the pr/qpg-mbedtls-update branch from 8c48f50 to 46de4e0 Compare May 8, 2023 09:56
@github-actions github-actions bot removed the examples label May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

PR #26416: Size comparison from 6c0c5ea to 46de4e0

Increases (1 build for cc32xx)
platform target config section 6c0c5ea 46de4e0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19609755 19609756 1 0.0
Full report (1 build for cc32xx)
platform target config section 6c0c5ea 46de4e0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605090 605090 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957621 957621 0 0.0
.debug_aranges 101136 101136 0 0.0
.debug_frame 341512 341512 0 0.0
.debug_info 19609755 19609756 1 0.0
.debug_line 2666632 2666632 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1489225 1489225 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94315 94315 0 0.0
.debug_str 3108982 3108982 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104354 104354 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483384 483384 0 0.0
.symtab 287328 287328 0 0.0
.text 498612 498612 0 0.0

@q-thla q-thla force-pushed the pr/qpg-mbedtls-update branch from 46de4e0 to ef57ef4 Compare May 8, 2023 10:10
@github-actions
Copy link

github-actions bot commented May 8, 2023

PR #26416: Size comparison from 6c0c5ea to ef57ef4

Full report (1 build for cc32xx)
platform target config section 6c0c5ea ef57ef4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605090 605090 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957621 957621 0 0.0
.debug_aranges 101136 101136 0 0.0
.debug_frame 341512 341512 0 0.0
.debug_info 19609755 19609755 0 0.0
.debug_line 2666632 2666632 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1489225 1489225 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94315 94315 0 0.0
.debug_str 3108982 3108982 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104354 104354 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483384 483384 0 0.0
.symtab 287328 287328 0 0.0
.text 498612 498612 0 0.0

@tima-q tima-q added the qpg QPG6xxx platform label May 8, 2023
@andy31415
Copy link
Contributor

@q-thla for the summary, it would be beneficial to explain changes on why something is done.

This description says what is happening, but not the reason for the change.

@q-thla q-thla force-pushed the pr/qpg-mbedtls-update branch from ef57ef4 to f1ed22c Compare May 9, 2023 06:27
@github-actions
Copy link

github-actions bot commented May 9, 2023

PR #26416: Size comparison from 05d9050 to f1ed22c

Increases above 0.2%:

platform target config section 05d9050 f1ed22c change % change
qpg lighting-app qpg6105+debug .text 615332 616716 1384 0.2
lock-app qpg6105+debug .text 585176 586584 1408 0.2
Increases (4 builds for bl702, nrfconnect, qpg)
platform target config section 05d9050 f1ed22c change % change
bl702 lighting-app bl702 .debug_info 40943088 40943089 1 0.0
.text 965470 965472 2 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 777932 777936 4 0.0
qpg lighting-app qpg6105+debug (read/write) 1168232 1169616 1384 0.1
.text 615332 616716 1384 0.2
lock-app qpg6105+debug (read/write) 1138076 1139484 1408 0.1
.text 585176 586584 1408 0.2
Decreases (3 builds for bl602, bl702, cc32xx)
platform target config section 05d9050 f1ed22c change % change
bl602 lighting-app bl602 (read/write) 1354998 1354990 -8 -0.0
.text 1035978 1035976 -2 -0.0
bl702 lighting-app bl702+rpc (read/write) 1273571 1273555 -16 -0.0
.debug_info 45848903 45848902 -1 -0.0
.text 1038098 1038096 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19674628 19674627 -1 -0.0
Full report (13 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect, qpg)
platform target config section 05d9050 f1ed22c change % change
bl602 lighting-app bl602 (read/write) 1354998 1354990 -8 -0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1035978 1035976 -2 -0.0
bl602+rpc (read/write) 1401266 1401266 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067332 1067332 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1185759 1185759 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1550204 1550204 0 0.0
.debug_aranges 132944 132944 0 0.0
.debug_frame 488804 488804 0 0.0
.debug_info 40943088 40943089 1 0.0
.debug_line 5301455 5301455 0 0.0
.debug_loc 3424613 3424613 0 0.0
.debug_ranges 372344 372344 0 0.0
.debug_str 3708223 3708223 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106304 106304 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580786 580786 0 0.0
.symtab 175264 175264 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 965470 965472 2 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1273571 1273555 -16 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1706954 1706954 0 0.0
.debug_aranges 141224 141224 0 0.0
.debug_frame 516776 516776 0 0.0
.debug_info 45848903 45848902 -1 -0.0
.debug_line 5716360 5716360 0 0.0
.debug_loc 3626917 3626917 0 0.0
.debug_ranges 397648 397648 0 0.0
.debug_str 4133328 4133328 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120144 120144 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641456 641456 0 0.0
.symtab 193600 193600 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1038098 1038096 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605002 605002 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342080 342080 0 0.0
.debug_info 19674628 19674627 -1 -0.0
.debug_line 2671903 2671903 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491139 1491139 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131828 3131828 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287232 287232 0 0.0
.text 498564 498564 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12248540 12248540 0 0.0
(read/write) 746680 746680 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 688336 688336 0 0.0
.dynamic 560 560 0 0.0
.got 15752 15752 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 569424 569424 0 0.0
.text 9906500 9906500 0 0.0
thermostat-no-ble arm64 (read only) 2525028 2525028 0 0.0
(read/write) 145768 145768 0 0.0
.bss 56392 56392 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 78048 78048 0 0.0
.dynamic 560 560 0 0.0
.got 5456 5456 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 129848 129848 0 0.0
.text 2130960 2130960 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495056 2495056 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1457740 1457740 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1176352 1176352 0 0.0
bss 155563 155563 0 0.0
rodata 132752 132752 0 0.0
text 807276 807276 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123444 1123444 0 0.0
bss 154757 154757 0 0.0
rodata 109748 109748 0 0.0
text 778212 778212 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1436080 1436080 0 0.0
bss 135303 135303 0 0.0
rodata 228768 228768 0 0.0
text 777932 777936 4 0.0
qpg lighting-app qpg6105+debug (read/write) 1168232 1169616 1384 0.1
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 615332 616716 1384 0.2
lock-app qpg6105+debug (read/write) 1138076 1139484 1408 0.1
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 585176 586584 1408 0.2

@andy31415 andy31415 merged commit 7e69af7 into project-chip:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
qpg QPG6xxx platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@q-thla @andy31415 @bzbarsky-apple @tima-q @adamb-q