Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add element accessors on Span. #26366

Merged
merged 2 commits into from
May 5, 2023
Merged

Add element accessors on Span. #26366

merged 2 commits into from
May 5, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This matches std::span and avoids people having to write span.data()[index] and whatnot.

@github-actions
Copy link

github-actions bot commented May 4, 2023

PR #26366: Size comparison from 5ff1818 to cbca484

Increases above 0.2%:

platform target config section 5ff1818 cbca484 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19522698 19603075 80377 0.4
.debug_str 3100491 3108084 7593 0.2
Increases (1 build for cc32xx)
platform target config section 5ff1818 cbca484 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 957005 957087 82 0.0
.debug_info 19522698 19603075 80377 0.4
.debug_line 2666219 2666227 8 0.0
.debug_loclists 1488771 1488792 21 0.0
.debug_str 3100491 3108084 7593 0.2
Full report (1 build for cc32xx)
platform target config section 5ff1818 cbca484 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604866 604866 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957005 957087 82 0.0
.debug_aranges 101104 101104 0 0.0
.debug_frame 341416 341416 0 0.0
.debug_info 19522698 19603075 80377 0.4
.debug_line 2666219 2666227 8 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488771 1488792 21 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94291 94291 0 0.0
.debug_str 3100491 3108084 7593 0.2
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104346 104346 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 482872 482872 0 0.0
.symtab 287120 287120 0 0.0
.text 498396 498396 0 0.0

@bzbarsky-apple
Add element accessors on Span.
61819f0 
This matches std::span and avoids people having to write span.data()[index] and
whatnot.
@bzbarsky-apple bzbarsky-apple force-pushed the span-element-accessors branch from cbca484 to 61819f0 Compare May 4, 2023 17:45
@github-actions
Copy link

github-actions bot commented May 4, 2023

PR #26366: Size comparison from de1c64a to 61819f0

Increases above 0.2%:

platform target config section de1c64a 61819f0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19522697 19603076 80379 0.4
.debug_str 3100491 3108084 7593 0.2
Increases (1 build for cc32xx)
platform target config section de1c64a 61819f0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 957005 957087 82 0.0
.debug_info 19522697 19603076 80379 0.4
.debug_line 2666219 2666227 8 0.0
.debug_loclists 1488771 1488792 21 0.0
.debug_str 3100491 3108084 7593 0.2
Full report (1 build for cc32xx)
platform target config section de1c64a 61819f0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604866 604866 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957005 957087 82 0.0
.debug_aranges 101104 101104 0 0.0
.debug_frame 341416 341416 0 0.0
.debug_info 19522697 19603076 80379 0.4
.debug_line 2666219 2666227 8 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488771 1488792 21 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94291 94291 0 0.0
.debug_str 3100491 3108084 7593 0.2
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104346 104346 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 482872 482872 0 0.0
.symtab 287120 287120 0 0.0
.text 498396 498396 0 0.0

@github-actions
Copy link

github-actions bot commented May 4, 2023

PR #26366: Size comparison from de1c64a to 7793216

Increases above 0.2%:

platform target config section de1c64a 7793216 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19522697 19603113 80416 0.4
.debug_str 3100491 3108084 7593 0.2
Increases (1 build for cc32xx)
platform target config section de1c64a 7793216 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 957005 957098 93 0.0
.debug_info 19522697 19603113 80416 0.4
.debug_line 2666219 2666235 16 0.0
.debug_loclists 1488771 1488792 21 0.0
.debug_str 3100491 3108084 7593 0.2
Full report (1 build for cc32xx)
platform target config section de1c64a 7793216 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604866 604866 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957005 957098 93 0.0
.debug_aranges 101104 101104 0 0.0
.debug_frame 341416 341416 0 0.0
.debug_info 19522697 19603113 80416 0.4
.debug_line 2666219 2666235 16 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488771 1488792 21 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94291 94291 0 0.0
.debug_str 3100491 3108084 7593 0.2
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104346 104346 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 482872 482872 0 0.0
.symtab 287120 287120 0 0.0
.text 498396 498396 0 0.0

yunhanw-google
yunhanw-google approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@yunhanw-google yunhanw-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bzbarsky-apple bzbarsky-apple merged commit 9556cc3 into project-chip:master May 5, 2023
@bzbarsky-apple bzbarsky-apple deleted the span-element-accessors branch May 5, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@arkq arkq arkq approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
lib review - approved support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @arkq @yunhanw-google