-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chip-repl hits the Code is unsafe/racy assert when BLE commissioning is started #26338
Merged
andy31415
merged 6 commits into
project-chip:master
from
tehampson:fix-chip-repl-ble-crash
May 5, 2023
Merged
chip-repl hits the Code is unsafe/racy assert when BLE commissioning is started #26338
andy31415
merged 6 commits into
project-chip:master
from
tehampson:fix-chip-repl-ble-crash
May 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
May 2, 2023 19:40
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 2, 2023 19:41
PR #26338: Size comparison from 8f66f42 to 22d4958 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
May 3, 2023
tehampson
commented
May 3, 2023
tehampson
commented
May 3, 2023
bzbarsky-apple
approved these changes
May 4, 2023
andy31415
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26265
PR #26180 added assert on the task ownership of the chip Stack lock on some SystemLayer timer calls.
The Linux ChipDeviceScanner starts a SystemLayer timer on the BLE connection which now asserts.
This pr fix the assert on SystemLayer().StartTimer call by acquiring the chipStack Lock before the call (and releasing it after)
Tested the fix by successfully starting to scan chip-repl