Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods for doing schema-checks on response-value dictionaries. #26321

Merged
merged 5 commits into from
May 9, 2023
Merged

Add methods for doing schema-checks on response-value dictionaries. #26321

merged 5 commits into from
May 9, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This adds a way to initialize an MTRAttributeReport or MTREventReport from a response-value dictionary, if we have known schema for the attribute/event path.

Fixes #26305

@github-actions github-actions bot added the darwin label May 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

PR #26321: Size comparison from 3144434 to 96a9fbd

Full report (1 build for cc32xx)
platform target config section 3144434 96a9fbd change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604042 604042 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956764 956764 0 0.0
.debug_aranges 103240 103240 0 0.0
.debug_frame 349432 349432 0 0.0
.debug_info 19559511 19559511 0 0.0
.debug_line 2687404 2687404 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1515630 1515630 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 95966 95966 0 0.0
.debug_str 3082308 3082308 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104282 104282 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 479192 479192 0 0.0
.symtab 286736 286736 0 0.0
.text 497636 497636 0 0.0

@github-actions
Copy link

github-actions bot commented May 2, 2023

PR #26321: Size comparison from 3144434 to dc94f66

Increases above 0.2%:

platform target config section 3144434 dc94f66 change % change
cc32xx lock CC3235SF_LAUNCHXL .strtab 479192 480350 1158 0.2
Increases (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
platform target config section 3144434 dc94f66 change % change
bl602 lighting-app bl602 (read/write) 1353994 1354458 464 0.0
.text 1035002 1035446 444 0.0
bl602+rpc (read/write) 1400262 1400734 472 0.0
.text 1066360 1066806 446 0.0
bl702 lighting-app bl702 (read/write) 1184623 1184831 208 0.0
.debug_abbrev 1549374 1549462 88 0.0
.rodata 106224 106240 16 0.0
.strtab 578407 579409 1002 0.2
.symtab 175008 175136 128 0.1
.text 964392 964580 188 0.0
bl702+rpc (read/write) 1272179 1272371 192 0.0
.debug_abbrev 1702654 1702742 88 0.0
.rodata 120064 120080 16 0.0
.strtab 638951 639953 1002 0.2
.symtab 193296 193424 128 0.1
.text 1036786 1036972 186 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 604042 604426 384 0.1
.debug_abbrev 956764 956872 108 0.0
.rodata 104282 104298 16 0.0
.strtab 479192 480350 1158 0.2
.symtab 286736 287024 288 0.1
.text 497636 498004 368 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2496168 2496432 264 0.0
.text 1458852 1459116 264 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177628 1177896 268 0.0
rodata 132892 132920 28 0.0
text 808416 808660 244 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1122768 1123040 272 0.0
rodata 109712 109728 16 0.0
text 777704 777948 244 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read/write) 1437324 1437592 268 0.0
rodata 228908 228936 28 0.0
text 779036 779276 240 0.0
qpg lighting-app qpg6105+debug (read/write) 1167360 1167616 256 0.0
.text 614460 614716 256 0.0
lock-app qpg6105+debug (read/write) 1136720 1136976 256 0.0
.text 583816 584072 256 0.0
Decreases (3 builds for bl702, cc32xx)
platform target config section 3144434 dc94f66 change % change
bl702 lighting-app bl702 .debug_aranges 134968 132744 -2224 -1.6
.debug_frame 496512 487708 -8804 -1.8
.debug_info 40778182 40736901 -41281 -0.1
.debug_line 5325334 5291774 -33560 -0.6
.debug_loc 3459082 3415797 -43285 -1.3
.debug_ranges 374904 371896 -3008 -0.8
.debug_str 3658703 3645006 -13697 -0.4
bl702+rpc .debug_aranges 143192 140968 -2224 -1.6
.debug_frame 524404 515600 -8804 -1.7
.debug_info 45473158 45431971 -41187 -0.1
.debug_line 5734761 5701205 -33556 -0.6
.debug_loc 3660051 3616850 -43201 -1.2
.debug_ranges 399936 396928 -3008 -0.8
.debug_str 4083124 4069427 -13697 -0.3
cc32xx lock CC3235SF_LAUNCHXL .debug_aranges 103240 101056 -2184 -2.1
.debug_frame 349432 341168 -8264 -2.4
.debug_info 19559511 19511284 -48227 -0.2
.debug_line 2687404 2664965 -22439 -0.8
.debug_loclists 1515630 1486884 -28746 -1.9
.debug_rnglists 95966 94239 -1727 -1.8
.debug_str 3082308 3068127 -14181 -0.5
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
platform target config section 3144434 dc94f66 change % change
bl602 lighting-app bl602 (read/write) 1353994 1354458 464 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1035002 1035446 444 0.0
bl602+rpc (read/write) 1400262 1400734 472 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1066360 1066806 446 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1184623 1184831 208 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67601 67601 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1549374 1549462 88 0.0
.debug_aranges 134968 132744 -2224 -1.6
.debug_frame 496512 487708 -8804 -1.8
.debug_info 40778182 40736901 -41281 -0.1
.debug_line 5325334 5291774 -33560 -0.6
.debug_loc 3459082 3415797 -43285 -1.3
.debug_ranges 374904 371896 -3008 -0.8
.debug_str 3658703 3645006 -13697 -0.4
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106224 106240 16 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 578407 579409 1002 0.2
.symtab 175008 175136 128 0.1
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 964392 964580 188 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1272179 1272371 192 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1702654 1702742 88 0.0
.debug_aranges 143192 140968 -2224 -1.6
.debug_frame 524404 515600 -8804 -1.7
.debug_info 45473158 45431971 -41187 -0.1
.debug_line 5734761 5701205 -33556 -0.6
.debug_loc 3660051 3616850 -43201 -1.2
.debug_ranges 399936 396928 -3008 -0.8
.debug_str 4083124 4069427 -13697 -0.3
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120064 120080 16 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 638951 639953 1002 0.2
.symtab 193296 193424 128 0.1
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1036786 1036972 186 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604042 604426 384 0.1
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956764 956872 108 0.0
.debug_aranges 103240 101056 -2184 -2.1
.debug_frame 349432 341168 -8264 -2.4
.debug_info 19559511 19511284 -48227 -0.2
.debug_line 2687404 2664965 -22439 -0.8
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1515630 1486884 -28746 -1.9
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 95966 94239 -1727 -1.8
.debug_str 3082308 3068127 -14181 -0.5
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104282 104298 16 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 479192 480350 1158 0.2
.symtab 286736 287024 288 0.1
.text 497636 498004 368 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2496168 2496432 264 0.0
.bss 216296 216296 0 0.0
.data 5144 5144 0 0.0
.text 1458852 1459116 264 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1177628 1177896 268 0.0
bss 155593 155593 0 0.0
rodata 132892 132920 28 0.0
text 808416 808660 244 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1122768 1123040 272 0.0
bss 154749 154749 0 0.0
rodata 109712 109728 16 0.0
text 777704 777948 244 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1437324 1437592 268 0.0
bss 135333 135333 0 0.0
rodata 228908 228936 28 0.0
text 779036 779276 240 0.0
qpg lighting-app qpg6105+debug (read/write) 1167360 1167616 256 0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 614460 614716 256 0.0
lock-app qpg6105+debug (read/write) 1136720 1136976 256 0.0
.bss 94784 94784 0 0.0
.data 852 852 0 0.0
.text 583816 584072 256 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the add-conversion-methods branch from dc94f66 to fadc8e9 Compare May 2, 2023 15:47
@github-actions
Copy link

github-actions bot commented May 2, 2023

PR #26321: Size comparison from 7be1954 to 88f187b

Decreases (1 build for cc32xx)
platform target config section 7be1954 88f187b change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19511285 19511284 -1 -0.0
Full report (5 builds for cc32xx, mbed, nrfconnect)
platform target config section 7be1954 88f187b change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604426 604426 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956872 956872 0 0.0
.debug_aranges 101056 101056 0 0.0
.debug_frame 341168 341168 0 0.0
.debug_info 19511285 19511284 -1 -0.0
.debug_line 2664965 2664965 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1486884 1486884 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94239 94239 0 0.0
.debug_str 3068127 3068127 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104298 104298 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 480350 480350 0 0.0
.symtab 287024 287024 0 0.0
.text 498004 498004 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2496432 2496432 0 0.0
.bss 216296 216296 0 0.0
.data 5144 5144 0 0.0
.text 1459116 1459116 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1177896 1177896 0 0.0
bss 155593 155593 0 0.0
rodata 132920 132920 0 0.0
text 808660 808660 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123040 1123040 0 0.0
bss 154749 154749 0 0.0
rodata 109728 109728 0 0.0
text 777948 777948 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1437592 1437592 0 0.0
bss 135333 135333 0 0.0
rodata 228936 228936 0 0.0
text 779280 779280 0 0.0

@github-actions github-actions bot added the system label May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

PR #26321: Size comparison from 7be1954 to d393274

Increases (1 build for cc32xx)
platform target config section 7be1954 d393274 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 956872 956935 63 0.0
.debug_info 19511285 19511313 28 0.0
.debug_loclists 1486884 1486894 10 0.0
Full report (1 build for cc32xx)
platform target config section 7be1954 d393274 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604426 604426 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956872 956935 63 0.0
.debug_aranges 101056 101056 0 0.0
.debug_frame 341168 341168 0 0.0
.debug_info 19511285 19511313 28 0.0
.debug_line 2664965 2664965 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1486884 1486894 10 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94239 94239 0 0.0
.debug_str 3068127 3068127 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104298 104298 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 480350 480350 0 0.0
.symtab 287024 287024 0 0.0
.text 498004 498004 0 0.0

@github-actions
Copy link

github-actions bot commented May 3, 2023

PR #26321: Size comparison from 7be1954 to 84444cb

Increases (1 build for cc32xx)
platform target config section 7be1954 84444cb change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 956872 956935 63 0.0
.debug_info 19511285 19511312 27 0.0
.debug_loclists 1486884 1486894 10 0.0
Full report (1 build for cc32xx)
platform target config section 7be1954 84444cb change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604426 604426 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956872 956935 63 0.0
.debug_aranges 101056 101056 0 0.0
.debug_frame 341168 341168 0 0.0
.debug_info 19511285 19511312 27 0.0
.debug_line 2664965 2664965 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1486884 1486894 10 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94239 94239 0 0.0
.debug_str 3068127 3068127 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104298 104298 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 480350 480350 0 0.0
.symtab 287024 287024 0 0.0
.text 498004 498004 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the add-conversion-methods branch from 84444cb to 4d7792a Compare May 3, 2023 19:26
@github-actions github-actions bot removed the system label May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

PR #26321: Size comparison from 7b60592 to 4d7792a

Increases (1 build for cc32xx)
platform target config section 7b60592 4d7792a change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19522329 19522330 1 0.0
Full report (1 build for cc32xx)
platform target config section 7b60592 4d7792a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604730 604730 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957005 957005 0 0.0
.debug_aranges 101104 101104 0 0.0
.debug_frame 341416 341416 0 0.0
.debug_info 19522329 19522330 1 0.0
.debug_line 2666090 2666090 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488725 1488725 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94279 94279 0 0.0
.debug_str 3100491 3100491 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104298 104298 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 482872 482872 0 0.0
.symtab 287120 287120 0 0.0
.text 498308 498308 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 51092c9 into project-chip:master May 9, 2023
@bzbarsky-apple bzbarsky-apple deleted the add-conversion-methods branch May 9, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jake-apple jake-apple jake-apple left review comments

@jtung-apple jtung-apple jtung-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Matter framework API for converting data-value dictionaries into strongly typed structs
4 participants
@bzbarsky-apple @andy31415 @jtung-apple @jake-apple