Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a recursion depth limit for TLV #26301

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

andy31415
Copy link
Contributor

Without this, a package of start list/structure that repeats can overflow the stack for ::Iterate since that is a recursive function.

@github-actions github-actions bot added core documentation Improvements or additions to documentation lib labels Apr 28, 2023
@github-actions
Copy link

PR #26301: Size comparison from 77d72a8 to ff72851

Increases (1 build for cc32xx)
platform target config section 77d72a8 ff72851 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 602714 602722 8 0.0
.debug_abbrev 956984 956996 12 0.0
.debug_info 19521972 19522048 76 0.0
.debug_line 2682751 2682783 32 0.0
.debug_loclists 1506147 1506228 81 0.0
.debug_str 3059490 3059509 19 0.0
.text 496340 496348 8 0.0
Full report (1 build for cc32xx)
platform target config section 77d72a8 ff72851 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 602714 602722 8 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956984 956996 12 0.0
.debug_aranges 103664 103664 0 0.0
.debug_frame 350552 350552 0 0.0
.debug_info 19521972 19522048 76 0.0
.debug_line 2682751 2682783 32 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1506147 1506228 81 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 96278 96278 0 0.0
.debug_str 3059490 3059509 19 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104250 104250 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 481887 481887 0 0.0
.symtab 287248 287248 0 0.0
.text 496340 496348 8 0.0

@andy31415 andy31415 merged commit af6cb3a into project-chip:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation Improvements or additions to documentation lib review - approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants