-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Move NVM semaphore creation to nvm3_lockBegin() #26270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule Also move nvm3_Sem creation to nvm3_lockBegin()
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
April 26, 2023 19:13
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk and
saurabhst
April 26, 2023 19:13
pullapprove
bot
requested review from
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
April 26, 2023 19:13
PR #26270: Size comparison from b1009b4 to ffc2fbf Full report (1 build for cc32xx)
|
jmartinez-silabs
approved these changes
Apr 26, 2023
selissia
changed the title
[Silabs] Move NVM initialization to sl_platform_init()
[Silabs] Move NVM semaphore creation to nvm3_lockBegin()
Apr 26, 2023
PR #26270: Size comparison from 32eef3e to 02deebd Full report (1 build for cc32xx)
|
andy31415
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move nvm3_Sem semaphore creation to nvm3_lockBegin() where it is guaranteed to be initialized on the first use.
Also update matter_support submodule to include NVM initialization from sl_platform_init, nvm3_open() is safe to be called multiple times.
Testing: Verified that a lighting app on BRD4161A successfully boots