-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] RS911x not going into power save upon power cycle #26260
Merged
jmartinez-silabs
merged 8 commits into
project-chip:master
from
rosahay-silabs:bugfix/power_save_fix
Apr 26, 2023
Merged
[Silabs] RS911x not going into power save upon power cycle #26260
jmartinez-silabs
merged 8 commits into
project-chip:master
from
rosahay-silabs:bugfix/power_save_fix
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26260: Size comparison from c2a28c8 to ac8e90d Increases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248 and
jelderton
April 26, 2023 11:03
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
April 26, 2023 11:03
PR #26260: Size comparison from c2a28c8 to 97a89ad Full report (1 build for cc32xx)
|
rosahay-silabs
approved these changes
Apr 26, 2023
jmartinez-silabs
approved these changes
Apr 26, 2023
bzbarsky-apple
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamping platform-specific fix.
PR #26260: Size comparison from c2a28c8 to 0b16eb2 Full report (1 build for cc32xx)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RS911x was not going into power save, i.e., sleepy once we are resetting the device.
Removed the power save call from ble and before connected notify to a single place i.e., upon station connect.
Added todo of ble of rs9116 since it was still advertising after join was happened.