[ON-OFF] Increase the size of the onoff cluster's eventControl array to handl… #26254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #26254: Size comparison from 85fd5ce to 223f391 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
requested changes
Apr 25, 2023
… the max dynamic enpoints count
…tains a specific cluster server, as stored in emAfEndpoints. Use it in Onoff cluster server to map the endpoint to the EventControl array of the server
jmartinez-silabs
force-pushed
the
OO_dynamic_ep
branch
from
223f391 to
922dc60
Compare
|
PR #26254: Size comparison from 0b4fba2 to 922dc60 Increases (4 builds for bl702, cc32xx, qpg)
Decreases (1 build for bl602)
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
|
bzbarsky-apple
requested changes
May 12, 2023
…usted to the cluster server implementation
…param name [-Werror,-Wdocumentation
Co-authored-by: Boris Zbarsky <[email protected]>
…t rest of the code
bzbarsky-apple
approved these changes
May 16, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
tehampson
approved these changes
May 16, 2023
tianfeng-yang
pushed a commit
to tianfeng-yang/connectedhomeip
that referenced
this pull request
May 17, 2023
…to handl… (project-chip#26254) * Increase the size of the onoff cluster's eventControl array to handle the max dynamic enpoints count * Create a new function to get the real index of the endpoint, that contains a specific cluster server, as stored in emAfEndpoints. Use it in Onoff cluster server to map the endpoint to the EventControl array of the server * Fix emberAfGetClusterServerEndpointIndex so the returned index is adjusted to the cluster server implementation * Update function brief as macOS Build complains about the : after the param name [-Werror,-Wdocumentation * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Add a VerifyorDie, Invert condition check for early return and outdent rest of the code * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e the max dynamic endpoint count.
fixes #26205