Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darwin] Fix MTRDeviceControllerStartupParams nocSigner empty issue #26246

Conversation

robinmo
Copy link
Contributor

@robinmo robinmo commented Apr 25, 2023

Fix #26240

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Robin.Gao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

PR #26246: Size comparison from bcf1b80 to 3d4a001

Increases (1 build for bl602)
platform target config section bcf1b80 3d4a001 change % change
bl602 lighting-app bl602 .text 1031746 1031748 2 0.0
Decreases (2 builds for bl702, nrfconnect)
platform target config section bcf1b80 3d4a001 change % change
bl702 lighting-app bl702 (read/write) 1179783 1179767 -16 -0.0
.debug_info 40756786 40756785 -1 -0.0
.text 959698 959696 -2 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 775788 775784 -4 -0.0
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
platform target config section bcf1b80 3d4a001 change % change
bl602 lighting-app bl602 (read/write) 1350630 1350630 0 0.0
.bss 87862 87862 0 0.0
.data 9648 9648 0 0.0
.text 1031746 1031748 2 0.0
bl602+rpc (read/write) 1396618 1396618 0 0.0
.bss 95910 95910 0 0.0
.data 10040 10040 0 0.0
.text 1062836 1062836 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1179783 1179767 -16 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67577 67577 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1549447 1549447 0 0.0
.debug_aranges 134696 134696 0 0.0
.debug_frame 495276 495276 0 0.0
.debug_info 40756786 40756785 -1 -0.0
.debug_line 5310222 5310222 0 0.0
.debug_loc 3445042 3445042 0 0.0
.debug_ranges 376512 376512 0 0.0
.debug_str 3596654 3596654 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106096 106096 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 573776 573776 0 0.0
.symtab 174304 174304 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 959698 959696 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1267867 1267867 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75609 75609 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1700147 1700147 0 0.0
.debug_aranges 142920 142920 0 0.0
.debug_frame 523156 523156 0 0.0
.debug_info 45249850 45249850 0 0.0
.debug_line 5717514 5717514 0 0.0
.debug_loc 3645630 3645630 0 0.0
.debug_ranges 401504 401504 0 0.0
.debug_str 4021065 4021065 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 119952 119952 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634778 634778 0 0.0
.symtab 192704 192704 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1032622 1032622 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 601114 601114 0 0.0
(read/write) 204132 204132 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197544 197544 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956756 956756 0 0.0
.debug_aranges 103416 103416 0 0.0
.debug_frame 349704 349704 0 0.0
.debug_info 19489249 19489249 0 0.0
.debug_line 2678035 2678035 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1501882 1501882 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 96008 96008 0 0.0
.debug_str 3024877 3024877 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104170 104170 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 477531 477531 0 0.0
.symtab 285936 285936 0 0.0
.text 494824 494824 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2492536 2492536 0 0.0
.bss 216272 216272 0 0.0
.data 5144 5144 0 0.0
.text 1455220 1455220 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1173892 1173892 0 0.0
bss 155557 155557 0 0.0
rodata 132740 132740 0 0.0
text 804836 804836 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1119140 1119140 0 0.0
bss 154713 154713 0 0.0
rodata 109556 109556 0 0.0
text 774228 774228 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1433952 1433952 0 0.0
bss 135297 135297 0 0.0
rodata 228784 228784 0 0.0
text 775788 775784 -4 -0.0
qpg lighting-app qpg6105+debug (read/write) 1163968 1163968 0 0.0
.bss 99616 99616 0 0.0
.data 856 856 0 0.0
.text 611068 611068 0 0.0
lock-app qpg6105+debug (read/write) 1133328 1133328 0 0.0
.bss 94768 94768 0 0.0
.data 852 852 0 0.0
.text 580424 580424 0 0.0

@robinmo
Copy link
Contributor Author

robinmo commented Apr 25, 2023

Create another one #26247

@robinmo robinmo closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Darwin: Try to use our own certificates failed during GenerateNOCChain - no nocSigner
2 participants