-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] merge LEDWidget #26222
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:silabs_platform_abstraction
Apr 25, 2023
Merged
[Silabs] merge LEDWidget #26222
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:silabs_platform_abstraction
Apr 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
force-pushed
the
silabs_platform_abstraction
branch
from
April 24, 2023 15:26
219304b
to
22e5d54
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
April 24, 2023 15:26
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
April 24, 2023 15:26
jmartinez-silabs
approved these changes
Apr 24, 2023
PR #26222: Size comparison from 05d79a2 to 22e5d54 Increases (8 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg)
Decreases (4 builds for cc13x2_26x2, cyw30739, nrfconnect, psoc6)
Full report (30 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, nrfconnect, psoc6, qpg)
|
andy31415
approved these changes
Apr 24, 2023
PR #26222: Size comparison from 05d79a2 to e406e89 Increases above 0.2%:
Increases (8 builds for bl602, bl702, cc32xx, mbed, qpg)
Decreases (7 builds for bl702, cc32xx, mbed, nrfconnect, qpg)
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Duplicated LEDWidget with the new platform abstraction class.
This PR also contains the fix proposed by @andy31415 on PR #26196