-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Add multiple interface for ESP32-C6 on all-clusters-app #26191
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
wqx6:esp32/multi_interfaces
May 23, 2023
Merged
ESP32: Add multiple interface for ESP32-C6 on all-clusters-app #26191
bzbarsky-apple
merged 2 commits into
project-chip:master
from
wqx6:esp32/multi_interfaces
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
April 21, 2023 08:20
pullapprove
bot
requested review from
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple and
xylophone21
April 21, 2023 08:20
PR #26191: Size comparison from f3f7ecd to d2cad81 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26191: Size comparison from c2a28c8 to 9a41702 Full report (2 builds for cc32xx, mbed)
|
PR #26191: Size comparison from 6c0c5ea to 70e81e0 Full report (1 build for cc32xx)
|
woody-apple
approved these changes
May 9, 2023
wqx6
force-pushed
the
esp32/multi_interfaces
branch
from
May 18, 2023 04:32
70e81e0
to
7c2e317
Compare
PR #26191: Size comparison from a295e01 to 7c2e317 Increases (41 builds for bl602, bl702, cyw30739, efr32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for esp32, psoc6)
Full report (56 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chshu
approved these changes
May 18, 2023
chshu
approved these changes
May 18, 2023
PR #26191: Size comparison from 1efbaf6 to b78ff62 Increases (39 builds for bl602, bl702, cyw30739, efr32, k32w, nrfconnect, qpg, telink)
Decreases (6 builds for bl602, efr32, esp32, psoc6)
Full report (56 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can enable the secondary network commissioning endpoint for ESP32-C6 on all-clusters-app so that we can pair ESP32-C6 to WiFi or Thread network with the following configurations.
Related to #26159
Then we can pair ESP32-C6 to a Wi-Fi network with the command:
Or pair C6 to a Thread network with the command:
Both of the commands should work on a firmware.