Stop storing two copies of attribute/event data in MTRDevice. #26181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
|
PR #26181: Size comparison from a14e6fb to 061bac1 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jtung-apple
approved these changes
Apr 20, 2023
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Apr 20, 2023
Since we were storing no data, we were computing clusterSize to 0 for all clusters in GetSortedFilters, and then we were not adding any DataVersion filters into our requests at all. The fix is that in "don't store data" mode we still store how big the data would have been, so we can correctly prioritize our DataVersion filters. Without this fix, the change in project-chip#26181 fails CI. That CI also acts as a test for this functionality, once project-chip#26181 happens.
andy31415
pushed a commit
that referenced
this pull request
Apr 24, 2023
#26187) Since we were storing no data, we were computing clusterSize to 0 for all clusters in GetSortedFilters, and then we were not adding any DataVersion filters into our requests at all. The fix is that in "don't store data" mode we still store how big the data would have been, so we can correctly prioritize our DataVersion filters. Without this fix, the change in #26181 fails CI. That CI also acts as a test for this functionality, once #26181 happens.
We have our own attribute value cache; we're just using ClusterStateCache to track DataVersions and event numbers.
bzbarsky-apple
force-pushed
the
stop-storing-data-cluster-cache-MTRDevice
branch
from
061bac1 to
80e71fd
Compare
|
PR #26181: Size comparison from 343634a to 80e71fd Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have our own attribute value cache; we're just using ClusterStateCache to track DataVersions and event numbers.