Fix leak when shutting down a controller with pending session setups. #26070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
pullapprove
bot
requested review from
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
vivien-apple
approved these changes
Apr 12, 2023
|
PR #26070: Size comparison from f25702c to eee1f6e Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
When shutting down a controller, we just destroyed its pending session setups
without notifying their consumers. This leaks, becase those consumers never get
a "setup has failed" notification and hence can't clean up properly.
A simple way to reproduce is to build darwin-framework-tool without ASAN
enabled, then run:
MallocStackLogging=YES leaks --atExit -- darwin-framework-tool onoff toggle 0xDEADBEEF 1
when no node with id 0xDEADBEEF is commissioned.
The fix is to send notifications when tearing down the OperationalSessionSetup,
if we have not notified yet.
bzbarsky-apple
force-pushed
the
fix-session-setup-leak
branch
from
eee1f6e to
0987d3f
Compare
|
PR #26070: Size comparison from 2ce04b5 to 0987d3f Increases (3 builds for cc32xx, qpg)
Full report (3 builds for cc32xx, qpg)
|
jmartinez-silabs
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shutting down a controller, we just destroyed its pending session setups without notifying their consumers. This leaks, becase those consumers never get a "setup has failed" notification and hence can't clean up properly.
A simple way to reproduce is to build darwin-framework-tool without ASAN enabled, then run:
when no node with id 0xDEADBEEF is commissioned.
The fix is to send notifications when tearing down the OperationalSessionSetup, if we have not notified yet.