Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo when checking cirque cache save action #26007

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Fix typo when checking cirque cache save action #26007

merged 2 commits into from
Apr 6, 2023

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Apr 6, 2023 •
edited
Loading

Problem

Due to typo, cirque docker cache is created even if GITHUB_ACTION_RUN was not set to 1.

Changes

  • fixed typo
  • fixed missing me variable

@github-actions
Copy link

github-actions bot commented Apr 6, 2023 •
edited
Loading

PR #26007: Size comparison from efaf3aa to 7bf6b75

Increases (5 builds for bl602, bl702, cc32xx, nrfconnect, psoc6)
platform target config section efaf3aa 7bf6b75 change % change
bl602 lighting-app bl602+rpc .text 1060508 1060510 2 0.0
bl702 lighting-app bl702 .debug_info 40755236 40755237 1 0.0
.text 957738 957740 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20302987 20302988 1 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 775532 775536 4 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 23157846 23157847 1 0.0
Decreases (5 builds for efr32, k32w, psoc6)
platform target config section efaf3aa 7bf6b75 change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1070728 1070712 -16 -0.0
.text 895424 895408 -16 -0.0
k32w contact k32w0+release (read/write) 673736 673720 -16 -0.0
.text 574580 574564 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 28088662 28088661 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27548069 27548067 -2 -0.0
light cy8ckit_062s2_43012 .debug_info 22906490 22906489 -1 -0.0
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
platform target config section efaf3aa 7bf6b75 change % change
bl602 lighting-app bl602 (read/write) 1355210 1355210 0 0.0
.bss 94778 94778 0 0.0
.data 9776 9776 0 0.0
.text 1029830 1029830 0 0.0
bl602+rpc (read/write) 1400382 1400382 0 0.0
.bss 102826 102826 0 0.0
.data 10168 10168 0 0.0
.text 1060508 1060510 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183687 1183687 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70721 70721 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 4088 4088 0 0.0
.debug_abbrev 1551688 1551688 0 0.0
.debug_aranges 133944 133944 0 0.0
.debug_frame 492632 492632 0 0.0
.debug_info 40755236 40755237 1 0.0
.debug_line 5298432 5298432 0 0.0
.debug_loc 3433903 3433903 0 0.0
.debug_ranges 374376 374376 0 0.0
.debug_str 3593197 3593197 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105664 105664 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572622 572622 0 0.0
.symtab 173744 173744 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
957738 957740 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1275171 1275171 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78769 78769 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4648 4648 0 0.0
.debug_abbrev 1703908 1703908 0 0.0
.debug_aranges 142304 142304 0 0.0
.debug_frame 520800 520800 0 0.0
.debug_info 45402318 45402318 0 0.0
.debug_line 5704695 5704695 0 0.0
.debug_loc 3632905 3632905 0 0.0
.debug_ranges 398376 398376 0 0.0
.debug_str 3997864 3997864 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 119888 119888 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634432 634432 0 0.0
.symtab 192368 192368 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1033756 1033756 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680695 680695 0 0.0
(read/write) 170560 170560 0 0.0
.bss 80948 80948 0 0.0
.data 3352 3352 0 0.0
.rodata 87015 87015 0 0.0
.text 593364 593364 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643967 643967 0 0.0
(read/write) 157616 157616 0 0.0
.bss 80148 80148 0 0.0
.data 3352 3352 0 0.0
.rodata 76807 76807 0 0.0
.text 566840 566840 0 0.0
lock-ftd LP_CC2652R7 (read only) 678071 678071 0 0.0
(read/write) 170648 170648 0 0.0
.bss 78500 78500 0 0.0
.data 3316 3316 0 0.0
.rodata 75687 75687 0 0.0
.text 601904 601904 0 0.0
lock-mtd LP_CC2652R7 (read only) 664299 664299 0 0.0
(read/write) 179580 179580 0 0.0
.bss 73660 73660 0 0.0
.data 3316 3316 0 0.0
.rodata 102507 102507 0 0.0
.text 561312 561312 0 0.0
pump-app LP_CC2652R7 (read only) 690747 690747 0 0.0
(read/write) 158716 158716 0 0.0
.bss 78476 78476 0 0.0
.data 3280 3280 0 0.0
.rodata 89747 89747 0 0.0
.text 600520 600520 0 0.0
pump-controller-app LP_CC2652R7 (read only) 675643 675643 0 0.0
(read/write) 173956 173956 0 0.0
.bss 78612 78612 0 0.0
.data 3304 3304 0 0.0
.rodata 85499 85499 0 0.0
.text 589664 589664 0 0.0
shell LP_CC2652R7 (read only) 673550 673550 0 0.0
(read/write) 179776 179776 0 0.0
.bss 83020 83020 0 0.0
.data 3348 3348 0 0.0
.rodata 85310 85310 0 0.0
.text 587928 587928 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642745 642745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302987 20302988 1 0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 0 0 0 0.0
536336 536336 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 533506 533506 0 0.0
.app_xip_area 414076 414076 0 0.0
.bss 61848 61848 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 537882 537882 0 0.0
.app_xip_area 413164 413164 0 0.0
.bss 67128 67128 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 554766 554766 0 0.0
.app_xip_area 436096 436096 0 0.0
.bss 61136 61136 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1017712 1017712 0 0.0
.bss 178700 178700 0 0.0
.data 2128 2128 0 0.0
.text 836864 836864 0 0.0
BRD4187C (read/write) 1025324 1025324 0 0.0
.bss 159200 159200 0 0.0
.data 2776 2776 0 0.0
.text 838752 838752 0 0.0
lock-app BRD4161A+wf200 (read/write) 1070728 1070712 -16 -0.0
.bss 173140 173140 0 0.0
.data 2144 2144 0 0.0
.text 895424 895408 -16 -0.0
window-app BRD4187C (read/write) 1141548 1141548 0 0.0
.bss 143632 143632 0 0.0
.data 2668 2668 0 0.0
.text 970652 970652 0 0.0
k32w contact k32w0+release (read/write) 673736 673720 -16 -0.0
.bss 65532 65532 0 0.0
.data 2224 2224 0 0.0
.text 574580 574564 -16 -0.0
light k32w0+release (read/write) 672876 672876 0 0.0
.bss 65196 65196 0 0.0
.data 2212 2212 0 0.0
.text 574068 574068 0 0.0
lock k32w0+release (read/write) 627588 627588 0 0.0
.bss 63268 63268 0 0.0
.data 2136 2136 0 0.0
.text 547168 547168 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12113692 12113692 0 0.0
(read/write) 742616 742616 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 684496 684496 0 0.0
.dynamic 560 560 0 0.0
.got 15504 15504 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 566156 566156 0 0.0
.text 9785268 9785268 0 0.0
thermostat-no-ble arm64 (read only) 2500492 2500492 0 0.0
(read/write) 145192 145192 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77648 77648 0 0.0
.dynamic 560 560 0 0.0
.got 5360 5360 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 129400 129400 0 0.0
.text 2108784 2108784 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2465472 2465472 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1428116 1428116 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1173596 1173596 0 0.0
bss 155557 155557 0 0.0
rodata 132652 132652 0 0.0
text 804616 804616 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1433604 1433604 0 0.0
bss 135297 135297 0 0.0
rodata 228692 228692 0 0.0
text 775532 775536 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1118828 1118828 0 0.0
bss 154713 154713 0 0.0
rodata 109468 109468 0 0.0
text 774008 774008 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840840 840840 0 0.0
(read/write) 1760444 1760444 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1259797 1259797 0 0.0
.debug_aranges 111816 111816 0 0.0
.debug_frame 376196 376196 0 0.0
.debug_info 28088662 28088661 -1 -0.0
.debug_line 3822069 3822069 0 0.0
.debug_loc 3723184 3723184 0 0.0
.debug_ranges 368016 368016 0 0.0
.debug_str 3550474 3550474 0 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 582791 582791 0 0.0
.symtab 426640 426640 0 0.0
.text 1559552 1559552 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841648 841648 0 0.0
(read/write) 1700484 1700484 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189064 189064 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1241661 1241661 0 0.0
.debug_aranges 110968 110968 0 0.0
.debug_frame 378280 378280 0 0.0
.debug_info 27548069 27548067 -2 -0.0
.debug_line 3825472 3825472 0 0.0
.debug_loc 3705254 3705254 0 0.0
.debug_ranges 365864 365864 0 0.0
.debug_str 3536400 3536400 0 0.0
.heap 841648 841648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 541993 541993 0 0.0
.symtab 411456 411456 0 0.0
.text 1500400 1500400 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849912 849912 0 0.0
(read/write) 1614212 1614212 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180968 180968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1076959 1076959 0 0.0
.debug_aranges 103176 103176 0 0.0
.debug_frame 348560 348560 0 0.0
.debug_info 22906490 22906489 -1 -0.0
.debug_line 3376393 3376393 0 0.0
.debug_loc 3380061 3380061 0 0.0
.debug_ranges 324400 324400 0 0.0
.debug_str 3335079 3335079 0 0.0
.heap 849912 849912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477080 477080 0 0.0
.symtab 379088 379088 0 0.0
.text 1422392 1422392 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 822136 822136 0 0.0
(read/write) 1671364 1671364 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208728 208728 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1079191 1079191 0 0.0
.debug_aranges 103576 103576 0 0.0
.debug_frame 350300 350300 0 0.0
.debug_info 23157846 23157847 1 0.0
.debug_line 3378121 3378121 0 0.0
.debug_loc 3403928 3403928 0 0.0
.debug_ranges 327000 327000 0 0.0
.debug_str 3353596 3353596 0 0.0
.heap 822136 822136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 480477 480477 0 0.0
.symtab 381280 381280 0 0.0
.text 1451768 1451768 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153440 1153440 0 0.0
.bss 97404 97404 0 0.0
.data 852 852 0 0.0
.text 600536 600536 0 0.0
lock-app qpg6105+debug (read/write) 1122048 1122048 0 0.0
.bss 92540 92540 0 0.0
.data 856 856 0 0.0
.text 569148 569148 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

PR #26007: Size comparison from efaf3aa to 3ab0e88

Increases (1 build for cc32xx)
platform target config section efaf3aa 3ab0e88 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 933099 933119 20 0.0
.debug_info 20302987 20302991 4 0.0
.debug_line 2679748 2679759 11 0.0
Full report (1 build for cc32xx)
platform target config section efaf3aa 3ab0e88 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642745 642745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933119 20 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302987 20302991 4 0.0
.debug_line 2679748 2679759 11 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0

@andy31415 andy31415 merged commit 1d73d5c into project-chip:master Apr 6, 2023
@arkq arkq deleted the cirque-typo branch April 7, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
integrations review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arkq @yunhanw-google @bzbarsky-apple @andy31415