Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of darwin-framework-tool with progress logging disabled. #26006

Conversation

bzbarsky-apple
Copy link
Contributor

  • CustomFlowString is used even if progress logging is disabled.
  • The id variable in GetCommissionerNodeIdCommand was unused when progress logging was disabled.

* CustomFlowString is used even if progress logging is disabled.
* The id variable in GetCommissionerNodeIdCommand was unused when progress
  logging was disabled.
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

PR #26006: Size comparison from efaf3aa to 96599d0

Decreases (1 build for cc32xx)
platform target config section efaf3aa 96599d0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20302987 20302986 -1 -0.0
Full report (1 build for cc32xx)
platform target config section efaf3aa 96599d0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642745 642745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302987 20302986 -1 -0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific change with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit b8201bb into project-chip:master Apr 6, 2023
@bzbarsky-apple bzbarsky-apple deleted the darwin-tool-no-progress-logging branch April 6, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants