Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused IsController in src/protocols/secure_channel/Rendezvous… #25999

Conversation

vivien-apple
Copy link
Contributor

…Parameters.h

Problem

This code is unused as far as I can tell.

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

PR #25999: Size comparison from 14ffac0 to 392d3b0

Increases (2 builds for cc32xx, nrfconnect)
platform target config section 14ffac0 392d3b0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20302987 20302988 1 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 774004 774008 4 0.0
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section 14ffac0 392d3b0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642745 642745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302987 20302988 1 0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2465472 2465472 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1428116 1428116 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1173596 1173596 0 0.0
bss 155557 155557 0 0.0
rodata 132652 132652 0 0.0
text 804616 804616 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1118828 1118828 0 0.0
bss 154713 154713 0 0.0
rodata 109468 109468 0 0.0
text 774004 774008 4 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1433604 1433604 0 0.0
bss 135297 135297 0 0.0
rodata 228692 228692 0 0.0
text 775536 775536 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153440 1153440 0 0.0
.bss 97404 97404 0 0.0
.data 852 852 0 0.0
.text 600536 600536 0 0.0
lock-app qpg6105+debug (read/write) 1122048 1122048 0 0.0
.bss 92540 92540 0 0.0
.data 856 856 0 0.0
.text 569148 569148 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 905ee37 into project-chip:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants