Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow generators to override loader paths and loaders #25947

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Allow generators to override loader paths and loaders #25947

merged 4 commits into from
Apr 4, 2023

Conversation

andy31415
Copy link
Contributor

Since generators can in theory support external loaders, allow them to configure the jinja loader logic.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

PR #25947: Size comparison from bf6dc7b to 73107a7

Increases (1 build for qpg)
platform target config section bf6dc7b 73107a7 change % change
qpg lighting-app qpg6105+debug (read/write) 1152968 1152976 8 0.0
.text 600064 600072 8 0.0
Decreases (1 build for cc32xx)
platform target config section bf6dc7b 73107a7 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20310332 20310330 -2 -0.0
Full report (4 builds for cc32xx, mbed, qpg)
platform target config section bf6dc7b 73107a7 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301596 301596 0 0.0
.debug_info 20310332 20310330 -2 -0.0
.debug_line 2681125 2681125 0 0.0
.debug_loc 2827568 2827568 0 0.0
.debug_ranges 286448 286448 0 0.0
.debug_str 3041144 3041144 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380543 380543 0 0.0
.symtab 257472 257472 0 0.0
.text 537752 537752 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466536 2466536 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1429180 1429180 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152968 1152976 8 0.0
.bss 96036 96036 0 0.0
.data 852 852 0 0.0
.text 600064 600072 8 0.0
lock-app qpg6105+debug (read/write) 1121552 1121552 0 0.0
.bss 91172 91172 0 0.0
.data 856 856 0 0.0
.text 568652 568652 0 0.0

turon
turon approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@turon turon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@github-actions
Copy link

github-actions bot commented Apr 3, 2023 •
edited
Loading

PR #25947: Size comparison from bf6dc7b to d62810d

Increases (4 builds for cc13x2_26x2, psoc6, qpg)
platform target config section bf6dc7b d62810d change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 692307 692315 8 0.0
.text 600848 600856 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 28096001 28096002 1 0.0
light cy8ckit_062s2_43012 .debug_info 22913829 22913830 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1152968 1152976 8 0.0
.text 600064 600072 8 0.0
Decreases (8 builds for bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, nrfconnect)
platform target config section bf6dc7b d62810d change % change
bl702 lighting-app bl702 .debug_info 40760806 40760805 -1 -0.0
.text 957998 957996 -2 -0.0
bl702+rpc .debug_info 45407886 45407885 -1 -0.0
.text 1034270 1034268 -2 -0.0
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 157156 157148 -8 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20310332 20310330 -2 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 534234 534226 -8 -0.0
.app_xip_area 414804 414796 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 555654 555646 -8 -0.0
.app_xip_area 436984 436976 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1071624 1071616 -8 -0.0
.text 896320 896312 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 774368 774364 -4 -0.0
Full report (32 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg)
platform target config section bf6dc7b d62810d change % change
bl602 lighting-app bl602 (read/write) 1356842 1356842 0 0.0
.bss 94778 94778 0 0.0
.data 9776 9776 0 0.0
.text 1030088 1030088 0 0.0
bl602+rpc (read/write) 1402274 1402274 0 0.0
.bss 102826 102826 0 0.0
.data 10168 10168 0 0.0
.text 1061022 1061022 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1185015 1185015 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70721 70721 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 4088 4088 0 0.0
.debug_abbrev 1551719 1551719 0 0.0
.debug_aranges 134048 134048 0 0.0
.debug_frame 492940 492940 0 0.0
.debug_info 40760806 40760805 -1 -0.0
.debug_line 5299982 5299982 0 0.0
.debug_loc 3435610 3435610 0 0.0
.debug_ranges 374632 374632 0 0.0
.debug_str 3594957 3594957 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106736 106736 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 573959 573959 0 0.0
.symtab 173856 173856 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
957998 957996 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276835 1276835 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78769 78769 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4648 4648 0 0.0
.debug_abbrev 1703939 1703939 0 0.0
.debug_aranges 142408 142408 0 0.0
.debug_frame 521108 521108 0 0.0
.debug_info 45407886 45407885 -1 -0.0
.debug_line 5706245 5706245 0 0.0
.debug_loc 3634612 3634612 0 0.0
.debug_ranges 398632 398632 0 0.0
.debug_str 3999624 3999624 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121040 121040 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635769 635769 0 0.0
.symtab 192480 192480 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1034270 1034268 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 682575 682575 0 0.0
(read/write) 168680 168680 0 0.0
.bss 80948 80948 0 0.0
.data 3352 3352 0 0.0
.rodata 88535 88535 0 0.0
.text 593724 593724 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645903 645903 0 0.0
(read/write) 157616 157616 0 0.0
.bss 80148 80148 0 0.0
.data 3352 3352 0 0.0
.rodata 78407 78407 0 0.0
.text 567176 567176 0 0.0
lock-ftd LP_CC2652R7 (read only) 679511 679511 0 0.0
(read/write) 169208 169208 0 0.0
.bss 78500 78500 0 0.0
.data 3316 3316 0 0.0
.rodata 76783 76783 0 0.0
.text 602248 602248 0 0.0
lock-mtd LP_CC2652R7 (read only) 665755 665755 0 0.0
(read/write) 178124 178124 0 0.0
.bss 73660 73660 0 0.0
.data 3316 3316 0 0.0
.rodata 103595 103595 0 0.0
.text 561680 561680 0 0.0
pump-app LP_CC2652R7 (read only) 692307 692315 8 0.0
(read/write) 157156 157148 -8 -0.0
.bss 78476 78476 0 0.0
.data 3280 3280 0 0.0
.rodata 90979 90979 0 0.0
.text 600848 600856 8 0.0
pump-controller-app LP_CC2652R7 (read only) 677243 677243 0 0.0
(read/write) 172356 172356 0 0.0
.bss 78612 78612 0 0.0
.data 3304 3304 0 0.0
.rodata 86843 86843 0 0.0
.text 589920 589920 0 0.0
shell LP_CC2652R7 (read only) 674030 674030 0 0.0
(read/write) 179296 179296 0 0.0
.bss 83020 83020 0 0.0
.data 3348 3348 0 0.0
.rodata 85438 85438 0 0.0
.text 588280 588280 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301596 301596 0 0.0
.debug_info 20310332 20310330 -2 -0.0
.debug_line 2681125 2681125 0 0.0
.debug_loc 2827568 2827568 0 0.0
.debug_ranges 286448 286448 0 0.0
.debug_str 3041144 3041144 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380543 380543 0 0.0
.symtab 257472 257472 0 0.0
.text 0 0 0 0.0
537752 537752 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 534234 534226 -8 -0.0
.app_xip_area 414804 414796 -8 -0.0
.bss 61848 61848 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 538522 538522 0 0.0
.app_xip_area 413804 413804 0 0.0
.bss 67128 67128 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 555654 555646 -8 -0.0
.app_xip_area 436984 436976 -8 -0.0
.bss 61136 61136 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1019016 1019016 0 0.0
.bss 178700 178700 0 0.0
.data 2128 2128 0 0.0
.text 838168 838168 0 0.0
BRD4187C (read/write) 1026300 1026300 0 0.0
.bss 159200 159200 0 0.0
.data 2776 2776 0 0.0
.text 839728 839728 0 0.0
lock-app BRD4161A+wf200 (read/write) 1071624 1071616 -8 -0.0
.bss 173140 173140 0 0.0
.data 2144 2144 0 0.0
.text 896320 896312 -8 -0.0
window-app BRD4187C (read/write) 1142868 1142868 0 0.0
.bss 143632 143632 0 0.0
.data 2668 2668 0 0.0
.text 971972 971972 0 0.0
k32w contact k32w0+release (read/write) 674768 674768 0 0.0
.bss 65532 65532 0 0.0
.data 2224 2224 0 0.0
.text 575612 575612 0 0.0
light k32w0+release (read/write) 673828 673828 0 0.0
.bss 65196 65196 0 0.0
.data 2212 2212 0 0.0
.text 575020 575020 0 0.0
lock k32w0+release (read/write) 628500 628500 0 0.0
.bss 63268 63268 0 0.0
.data 2136 2136 0 0.0
.text 548080 548080 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466536 2466536 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1429180 1429180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1174124 1174124 0 0.0
bss 155557 155557 0 0.0
rodata 132652 132652 0 0.0
text 805156 805156 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1434148 1434148 0 0.0
bss 135297 135297 0 0.0
rodata 228692 228692 0 0.0
text 776076 776076 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1119196 1119196 0 0.0
bss 154713 154713 0 0.0
rodata 109468 109468 0 0.0
text 774368 774364 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840840 840840 0 0.0
(read/write) 1764196 1764196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1259828 1259828 0 0.0
.debug_aranges 111920 111920 0 0.0
.debug_frame 376476 376476 0 0.0
.debug_info 28096001 28096002 1 0.0
.debug_line 3823474 3823474 0 0.0
.debug_loc 3726051 3726051 0 0.0
.debug_ranges 368272 368272 0 0.0
.debug_str 3552234 3552234 0 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 584128 584128 0 0.0
.symtab 426928 426928 0 0.0
.text 1563304 1563304 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841648 841648 0 0.0
(read/write) 1704516 1704516 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189064 189064 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1241692 1241692 0 0.0
.debug_aranges 111072 111072 0 0.0
.debug_frame 378560 378560 0 0.0
.debug_info 27555407 27555407 0 0.0
.debug_line 3826871 3826871 0 0.0
.debug_loc 3708121 3708121 0 0.0
.debug_ranges 366120 366120 0 0.0
.debug_str 3538160 3538160 0 0.0
.heap 841648 841648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 543330 543330 0 0.0
.symtab 411744 411744 0 0.0
.text 1504432 1504432 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849912 849912 0 0.0
(read/write) 1617572 1617572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180968 180968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1076990 1076990 0 0.0
.debug_aranges 103280 103280 0 0.0
.debug_frame 348840 348840 0 0.0
.debug_info 22913829 22913830 1 0.0
.debug_line 3377792 3377792 0 0.0
.debug_loc 3382928 3382928 0 0.0
.debug_ranges 324656 324656 0 0.0
.debug_str 3336839 3336839 0 0.0
.heap 849912 849912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478417 478417 0 0.0
.symtab 379376 379376 0 0.0
.text 1425752 1425752 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 822136 822136 0 0.0
(read/write) 1674500 1674500 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208728 208728 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1079222 1079222 0 0.0
.debug_aranges 103680 103680 0 0.0
.debug_frame 350580 350580 0 0.0
.debug_info 23165239 23165239 0 0.0
.debug_line 3379548 3379548 0 0.0
.debug_loc 3406843 3406843 0 0.0
.debug_ranges 327256 327256 0 0.0
.debug_str 3355356 3355356 0 0.0
.heap 822136 822136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 481814 481814 0 0.0
.symtab 381568 381568 0 0.0
.text 1454904 1454904 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152968 1152976 8 0.0
.bss 96036 96036 0 0.0
.data 852 852 0 0.0
.text 600064 600072 8 0.0
lock-app qpg6105+debug (read/write) 1121552 1121552 0 0.0
.bss 91172 91172 0 0.0
.data 856 856 0 0.0
.text 568652 568652 0 0.0

@andy31415 andy31415 merged commit 9425ce9 into project-chip:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turon turon turon approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @turon