Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating Stateful Helpers #25883

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Deprecating Stateful Helpers #25883

merged 3 commits into from
Mar 31, 2023

Conversation

brdandu
Copy link
Contributor

@brdandu brdandu commented Mar 29, 2023 •
edited
Loading

  • Replacing chip_client_clusters, chip_cluster_commands, chip_cluster_responses and chip_cluster_command_arguments with all_user_clusters, zcl_commands, zcl_command_responses and zcl_command_arguments respectively in templates
  • Updating minimum zap vesion
  • Github: ZAP#971

@brdandu brdandu mentioned this pull request Mar 29, 2023
Closed
@brdandu
Replacing chip_client_clusters, chip_cluster_commands, chip_cluster_r…
cefb176 
…esponses and chip_cluster_command_arguments with all_user_clusters, zcl_commands, zcl_command_responses and zcl_command_arguments respectively in templates

- Updating minimum zap vesion
- Github: ZAP#971
@brdandu brdandu force-pushed the bug/fixClusterAndCommandStatefulnessJavaAndPythonTemplates/ZAP#971 branch from 472c678 to cefb176 Compare March 29, 2023 21:19
@github-actions
Copy link

PR #25883: Size comparison from 2aefaa6 to cefb176

Increases (12 builds for bl602, bl702, nrfconnect, psoc6, telink)
platform target config section 2aefaa6 cefb176 change % change
bl602 lighting-app bl602+rpc (read/write) 1405678 1405686 8 0.0
.text 1062968 1062970 2 0.0
bl702 lighting-app bl702 .debug_info 41081751 41081752 1 0.0
.text 962532 962534 2 0.0
bl702+rpc .debug_info 45735084 45735085 1 0.0
.text 1038550 1038552 2 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 774352 774356 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 28095712 28095714 2 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27555118 27555119 1 0.0
light cy8ckit_062s2_43012 .debug_info 22913540 22913541 1 0.0
telink all-clusters-minimal-app tlsr9518adk80d text 653470 653472 2 0.0
lighting-app-factory-data tlsr9518adk80d text 671848 671850 2 0.0
lighting-app-rpc tlsr9518adk80d (read/write) 1024924 1024932 8 0.0
text 707380 707382 2 0.0
thermostat tlsr9518adk80d text 599320 599324 4 0.0
window-covering tlsr9518adk80d (read/write) 944460 944468 8 0.0
text 650396 650398 2 0.0
Decreases (10 builds for bl602, cc32xx, efr32, esp32, qpg, telink)
platform target config section 2aefaa6 cefb176 change % change
bl602 lighting-app bl602 .text 1032036 1032034 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20310044 20310043 -1 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1071624 1071616 -8 -0.0
.text 896320 896312 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1052410 1052408 -2 -0.0
.flash.text 1052410 1052408 -2 -0.0
qpg lock-app qpg6105+debug (read/write) 1121528 1121520 -8 -0.0
.text 568628 568620 -8 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1023260 1023252 -8 -0.0
text 692434 692430 -4 -0.0
lock-app tlsr9518adk80d text 611594 611592 -2 -0.0
ota-requestor-app tlsr9518adk80d text 608318 608314 -4 -0.0
pump-app tlsr9518adk80d (read/write) 867516 867508 -8 -0.0
text 589372 589368 -4 -0.0
pump-controller-app tlsr9518adk80d text 579694 579692 -2 -0.0
Full report (50 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2aefaa6 cefb176 change % change
bl602 lighting-app bl602 (read/write) 1360246 1360246 0 0.0
.bss 94834 94834 0 0.0
.data 9776 9776 0 0.0
.text 1032036 1032034 -2 -0.0
bl602+rpc (read/write) 1405678 1405686 8 0.0
.bss 102882 102882 0 0.0
.data 10168 10168 0 0.0
.text 1062968 1062970 2 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1192471 1192471 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70113 70113 0 0.0
.bss_psram 26064 26064 0 0.0
.comment 48 48 0 0.0
.data 4096 4096 0 0.0
.debug_abbrev 1563203 1563203 0 0.0
.debug_aranges 135440 135440 0 0.0
.debug_frame 496680 496680 0 0.0
.debug_info 41081751 41081752 1 0.0
.debug_line 5329048 5329048 0 0.0
.debug_loc 3453935 3453935 0 0.0
.debug_ranges 377480 377480 0 0.0
.debug_str 3615526 3615526 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 148 148 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 108528 108528 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582151 582151 0 0.0
.symtab 175280 175280 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 962532 962534 2 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1284011 1284011 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78161 78161 0 0.0
.bss_psram 26464 26464 0 0.0
.comment 48 48 0 0.0
.data 4648 4648 0 0.0
.debug_abbrev 1715269 1715269 0 0.0
.debug_aranges 143800 143800 0 0.0
.debug_frame 524848 524848 0 0.0
.debug_info 45735084 45735085 1 0.0
.debug_line 5735502 5735502 0 0.0
.debug_loc 3652937 3652937 0 0.0
.debug_ranges 401480 401480 0 0.0
.debug_str 4020193 4020193 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 164 164 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122832 122832 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643961 643961 0 0.0
.symtab 193904 193904 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1038550 1038552 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 682567 682567 0 0.0
(read/write) 168688 168688 0 0.0
.bss 80948 80948 0 0.0
.data 3352 3352 0 0.0
.rodata 88535 88535 0 0.0
.text 593716 593716 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645895 645895 0 0.0
(read/write) 157616 157616 0 0.0
.bss 80148 80148 0 0.0
.data 3352 3352 0 0.0
.rodata 78407 78407 0 0.0
.text 567168 567168 0 0.0
lock-ftd LP_CC2652R7 (read only) 679503 679503 0 0.0
(read/write) 169216 169216 0 0.0
.bss 78500 78500 0 0.0
.data 3316 3316 0 0.0
.rodata 76783 76783 0 0.0
.text 602240 602240 0 0.0
lock-mtd LP_CC2652R7 (read only) 665739 665739 0 0.0
(read/write) 178140 178140 0 0.0
.bss 73660 73660 0 0.0
.data 3316 3316 0 0.0
.rodata 103587 103587 0 0.0
.text 561672 561672 0 0.0
pump-app LP_CC2652R7 (read only) 692283 692283 0 0.0
(read/write) 157180 157180 0 0.0
.bss 78476 78476 0 0.0
.data 3280 3280 0 0.0
.rodata 90963 90963 0 0.0
.text 600840 600840 0 0.0
pump-controller-app LP_CC2652R7 (read only) 677227 677227 0 0.0
(read/write) 172372 172372 0 0.0
.bss 78612 78612 0 0.0
.data 3304 3304 0 0.0
.rodata 86835 86835 0 0.0
.text 589912 589912 0 0.0
shell LP_CC2652R7 (read only) 674022 674022 0 0.0
(read/write) 179304 179304 0 0.0
.bss 83020 83020 0 0.0
.data 3348 3348 0 0.0
.rodata 85438 85438 0 0.0
.text 588272 588272 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645769 645769 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301596 301596 0 0.0
.debug_info 20310044 20310043 -1 -0.0
.debug_line 2681024 2681024 0 0.0
.debug_loc 2827360 2827360 0 0.0
.debug_ranges 286352 286352 0 0.0
.debug_str 3041144 3041144 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380543 380543 0 0.0
.symtab 257472 257472 0 0.0
.text 537696 537696 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 534226 534226 0 0.0
.app_xip_area 414796 414796 0 0.0
.bss 61848 61848 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 538514 538514 0 0.0
.app_xip_area 413796 413796 0 0.0
.bss 67128 67128 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 555646 555646 0 0.0
.app_xip_area 436976 436976 0 0.0
.bss 61136 61136 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1018960 1018960 0 0.0
.bss 178700 178700 0 0.0
.data 2128 2128 0 0.0
.text 838112 838112 0 0.0
lock-app BRD4161A+wf200 (read/write) 1071624 1071616 -8 -0.0
.bss 173140 173140 0 0.0
.data 2144 2144 0 0.0
.text 896320 896312 -8 -0.0
lighting-app BRD4187C (read/write) 1025980 1025980 0 0.0
.bss 159240 159240 0 0.0
.data 2776 2776 0 0.0
.text 839368 839368 0 0.0
window-app BRD4187C (read/write) 1142860 1142860 0 0.0
.bss 143664 143664 0 0.0
.data 2668 2668 0 0.0
.text 971932 971932 0 0.0
esp32 all-clusters-app c3devkit (read only) 1052410 1052408 -2 -0.0
(read/write) 1585994 1585994 0 0.0
.dram0.bss 77984 77984 0 0.0
.dram0.data 13752 13752 0 0.0
.flash.rodata 222496 222496 0 0.0
.flash.text 1052410 1052408 -2 -0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1104035 1104035 0 0.0
(read/write) 502075 502075 0 0.0
.dram0.bss 83024 83024 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 251240 251240 0 0.0
.flash.text 1098651 1098651 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 674768 674768 0 0.0
.bss 65532 65532 0 0.0
.data 2224 2224 0 0.0
.text 575612 575612 0 0.0
light k32w0+release (read/write) 673812 673812 0 0.0
.bss 65196 65196 0 0.0
.data 2212 2212 0 0.0
.text 575004 575004 0 0.0
lock k32w0+release (read/write) 628484 628484 0 0.0
.bss 63268 63268 0 0.0
.data 2136 2136 0 0.0
.text 548064 548064 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12133260 12133260 0 0.0
(read/write) 742616 742616 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 684496 684496 0 0.0
.dynamic 560 560 0 0.0
.got 15504 15504 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 585692 585692 0 0.0
.text 9785300 9785300 0 0.0
thermostat-no-ble arm64 (read only) 2525140 2525140 0 0.0
(read/write) 145208 145208 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77672 77672 0 0.0
.dynamic 560 560 0 0.0
.got 5360 5360 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150960 150960 0 0.0
.text 2111840 2111840 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466536 2466536 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1429180 1429180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1174112 1174112 0 0.0
bss 155557 155557 0 0.0
rodata 132640 132640 0 0.0
text 805148 805148 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1119168 1119168 0 0.0
bss 154713 154713 0 0.0
rodata 109456 109456 0 0.0
text 774352 774356 4 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1434132 1434132 0 0.0
bss 135297 135297 0 0.0
rodata 228692 228692 0 0.0
text 776068 776068 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840840 840840 0 0.0
(read/write) 1764148 1764148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1259828 1259828 0 0.0
.debug_aranges 111920 111920 0 0.0
.debug_frame 376476 376476 0 0.0
.debug_info 28095712 28095714 2 0.0
.debug_line 3823375 3823375 0 0.0
.debug_loc 3725843 3725843 0 0.0
.debug_ranges 368176 368176 0 0.0
.debug_str 3552045 3552045 0 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 584090 584090 0 0.0
.symtab 426928 426928 0 0.0
.text 1563256 1563256 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841648 841648 0 0.0
(read/write) 1704468 1704468 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189064 189064 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1241692 1241692 0 0.0
.debug_aranges 111072 111072 0 0.0
.debug_frame 378560 378560 0 0.0
.debug_info 27555118 27555119 1 0.0
.debug_line 3826772 3826772 0 0.0
.debug_loc 3707913 3707913 0 0.0
.debug_ranges 366024 366024 0 0.0
.debug_str 3537971 3537971 0 0.0
.heap 841648 841648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 543292 543292 0 0.0
.symtab 411744 411744 0 0.0
.text 1504384 1504384 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849912 849912 0 0.0
(read/write) 1617524 1617524 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180968 180968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1076990 1076990 0 0.0
.debug_aranges 103280 103280 0 0.0
.debug_frame 348840 348840 0 0.0
.debug_info 22913540 22913541 1 0.0
.debug_line 3377691 3377691 0 0.0
.debug_loc 3382720 3382720 0 0.0
.debug_ranges 324560 324560 0 0.0
.debug_str 3336845 3336845 0 0.0
.heap 849912 849912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478417 478417 0 0.0
.symtab 379376 379376 0 0.0
.text 1425704 1425704 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 822136 822136 0 0.0
(read/write) 1674452 1674452 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208728 208728 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1079222 1079222 0 0.0
.debug_aranges 103680 103680 0 0.0
.debug_frame 350580 350580 0 0.0
.debug_info 23164951 23164951 0 0.0
.debug_line 3379449 3379449 0 0.0
.debug_loc 3406635 3406635 0 0.0
.debug_ranges 327160 327160 0 0.0
.debug_str 3355356 3355356 0 0.0
.heap 822136 822136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 481814 481814 0 0.0
.symtab 381568 381568 0 0.0
.text 1454856 1454856 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152952 1152952 0 0.0
.bss 96036 96036 0 0.0
.data 852 852 0 0.0
.text 600048 600048 0 0.0
lock-app qpg6105+debug (read/write) 1121528 1121520 -8 -0.0
.bss 91172 91172 0 0.0
.data 856 856 0 0.0
.text 568628 568620 -8 -0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1023260 1023252 -8 -0.0
bss 98068 98068 0 0.0
text 692434 692430 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 958192 958192 0 0.0
bss 97120 97120 0 0.0
text 653470 653472 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 862100 862100 0 0.0
bss 89284 89284 0 0.0
text 583590 583590 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877964 877964 0 0.0
bss 89372 89372 0 0.0
text 597790 597790 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 956752 956752 0 0.0
bss 97500 97500 0 0.0
text 664276 664276 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 968104 968104 0 0.0
bss 101748 101748 0 0.0
text 671848 671850 2 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1024924 1024932 8 0.0
bss 99064 99064 0 0.0
text 707380 707382 2 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 916452 916452 0 0.0
bss 89936 89936 0 0.0
text 611594 611592 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890900 890900 0 0.0
bss 90296 90296 0 0.0
text 608318 608314 -4 -0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867516 867508 -8 -0.0
bss 89400 89400 0 0.0
text 589372 589368 -4 -0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 854768 854768 0 0.0
bss 89200 89200 0 0.0
text 579694 579692 -2 -0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 850564 850564 0 0.0
bss 89060 89060 0 0.0
text 575092 575092 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882108 882108 0 0.0
bss 90764 90764 0 0.0
text 599320 599324 4 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944460 944468 8 0.0
bss 99172 99172 0 0.0
text 650396 650398 2 0.0

@andy31415 andy31415 merged commit 55a377b into project-chip:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
controller integrations review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brdandu @andy31415 @bzbarsky-apple